search

NOAA-EMC / NCEPLIBS-external

Third-party libraries required by NCEPLIBS
Other
8 stars 16 forks source link

CMake wgrib2 #55

Closed kgerheiser closed 4 years ago

kgerheiser commented 4 years ago

Add the CMake wgrib2 to NCEPLIBS-external

Also had to change the Jasper version to 1.900.1 because wgrib2 wouldn't build with our 2.x.x version. I think this is correct anyway because it's the version all the supercomputers use.

kgerheiser commented 4 years ago

Seems to work

climbfuji commented 4 years ago

Looks promising! I noticed the "work in progess" label. When you think this is good, can you please try to remove the -DBUILD_WGRIB2=OFF from the macOS travis yml files, and see if it works with your changes? We will also need to change the repository for wgrib2 before the release tag 1.1.0 is created, we can't have a release pull code from a private repository.

kgerheiser commented 4 years ago

Good catch, didn't realize those were off.

kgerheiser commented 4 years ago

And my repo tag is just temporary

kgerheiser commented 4 years ago

I merged my wgrib2 changes and updated ExternalProject to use the official repo.

It should be good to go now.

climbfuji commented 4 years ago

That looks good - let me check it out and build it locally as well. Stay tuned ...