release/public-v2: final updates to Docker documentation before release

NOAA-EMC / NCEPLIBS-external

Third-party libraries required by NCEPLIBS

Other

8 stars 16 forks source link

release/public-v2: final updates to Docker documentation before release #91

Closed climbfuji closed 3 years ago

climbfuji commented 3 years ago

This PR contains the following changes:

fix formatting in final version of doc/README_docker_gnu.md

No testing required, documentation updates only. Will need to updatee the tag ufs-v2.0.0 after this PR is merged.

Waiting for final OK from @mkavulich before merging.

climbfuji commented 3 years ago

@mkavulich I addressed all your comments except the question about the graphics (chapter 6). I will need @SamuelTrahanNOAA to help me with that one.

SamuelTrahanNOAA commented 3 years ago

@climbfuji @mkavulich - I'd like to keep section 6 in, so people know where the output is even if they close the terminal that had the run_all.sh output.

mkavulich commented 3 years ago

@SamuelTrahanNOAA I'm not advocating for omitting section 6, I'm curious if the run_all script still includes the graphics generation (as it did when I ran my tests last week). If so, the graphics should be mentioned in section 5 and/or 6, if not, I'm okay with the PR as-is.

SamuelTrahanNOAA commented 3 years ago

The graphics are still in the container. I wrote the README.md before adding the graphics. I thought I had added all necessary details since then, but I guess I forgot some.

SamuelTrahanNOAA commented 3 years ago

@mkavulich - Dom just merged some changes from one of my PRs that updates sections 5 & 6. Please review them again.