search

NOAA-EMC / NCEPLIBS-g2

Utilities for coding/decoding GRIB2 messages.
Other
6 stars 15 forks source link

Fixing some code warnings in utils #724

Closed AlysonStahl-NOAA closed 3 months ago

AlysonStahl-NOAA commented 3 months ago

Fixes https://github.com/NOAA-EMC/NCEPLIBS-grib_util/issues/128 Fixes https://github.com/NOAA-EMC/NCEPLIBS-grib_util/issues/132

edwardhartnett commented 3 months ago

OK, this is a great PR. I hate warnings in the code, they just train us programmers to ignore (new) warnings. So the code can just keep getting worse and worse, if we don't fix all warnings and then demand a warning-free build in the CI.

But I'm a little worried about this PR, because our testing is not great (yet).

Can you submit a new PR with the code re-indent, and the unused variable warnings resolved? Those are the easy ones which we can be sure is not breaking anything.

Then, as a second pass, the code changes which remove parameters from the subroutine. That seems like a more serious edit and I would like to see that alone. Also we may wish to add more tests, and look at the code coverage report to make sure this code is being tested.

AlysonStahl-NOAA commented 3 months ago

Closing this one. See #728