Closed EricEngle-NOAA closed 8 months ago
Nice! Do you want me to merge this in before the 1.8.0 releaase?
@edwardhartnett - When are you planning to release v1.8.0?
I'm planning on releasing 1.8.0 today or early next week...
There were a couple of failed tests that I am working through. Does not seem major -- type mismatches. Going to push fixes soon.
This is happening on MacOS:
/Users/runner/work/NCEPLIBS-g2c/NCEPLIBS-g2c/g2c/tests/tst_aec.c:9:10: fatal error: 'libaec.h' file not found
Do you know how to install the AEC library on MacOS?
Yes. I am working on the missing aec header for macOS now.
I think it will be best to release early next week if the desire is to get AEC support in v1.8.0
Yay the macOS tests are passing with commit 16499e3
Now onto the Linux options tests
Next week is fine. I'm not ready yet... ;-)
Also do you have any real-world examples of data files compressed with AEC?
What is happening with the CI here? How come nothing is running?
Hmmm... I did put [skip ci]
in the last commit message for .gitignore.
These 8 jobs do not have aec parameters, so something got messed up somewhere. Still looking...
@edwardhartnett - I think somewhere in the GitHub CI, these 8 checks are "required", but these test do not exist anymore since I modified Linux_options and MacOS to include AEC parameters. In other words, these tests don't exist anymore, but they are required.
OK, I forgot that you modified the tests. Stand by...
🎉 Looks good! 🎉
@EricEngle-NOAA I'm going to merge this. Thanks very much for this contribution, it will benefit many other users as well.
Could you please find some smallish real-world data file that uses this kind of packing, so we can have a test file on our FTP site?
@edwardhartnett - It's been hard to find, but I can generate it. How many messages and what size limit should I consider?
Some small file would be good, so just a couple of messages...
Pull request for issue #424.
Changes in this pull request provide support for AEC/CCSDS compression in the g2c library as specified by DRT 5.42.
Tests have been created (tests/tst_aec.c) and are successful on my Fedora 38 VM (gcc 13.2)