search

NOAA-EMC / NCEPLIBS-g2c

This library contains C decoder/encoder routines for GRIB edition 2.
Other
17 stars 11 forks source link

Update for aecunpack.c #462

Closed EricEngle-NOAA closed 6 months ago

EricEngle-NOAA commented 7 months ago

This commit fixes a bug in aecunpack.c where the bytes from the decoded AEC buffer stream are not being properly copied into the ifld array. The AEC stream is byte aligned.

This commit references NOAA-EMC/NCEPLIBS-g2c#461

edwardhartnett commented 6 months ago

Testing?

EricEngle-NOAA commented 6 months ago

The existing tests for AEC compression using very small hardcoded data pass. Do you want a more complex test for AEC compression perhaps using ECMWF data -- 1 GRIB2 message?

edwardhartnett commented 6 months ago

Yes, please add more testing, that would be very helpful.

Have you looked at the code coverage report for your code?

EricEngle-NOAA commented 6 months ago

Re: code coverage. No. How do you do that?

edwardhartnett commented 6 months ago

For some reason your code is not appearing on the coverage report. I'm looking into that. Meanwhile, I will merge this PR and we will address more testing in another PR.