search

NOAA-EMC / NCEPLIBS-g2c

This library contains C decoder/encoder routines for GRIB edition 2.
Other
17 stars 11 forks source link

AEC code not appearing in code coverage report #467

Closed edwardhartnett closed 6 months ago

edwardhartnett commented 6 months ago

Maybe because of the way that it is being handled in CMake.

@EricEngle-NOAA this is why we can't see your code coverage...

edwardhartnett commented 6 months ago

OK, this was simple, the AEC features were not turned on in the developer.yml workflow, which is where the code coverage report is generated. I've turned it on and now I see code coverage. Once #468 merges it will be fixed.

@EricEngle-NOAA to see code coverage, look in the developer/asan workflow, and you will find a zip file you can download. Download it, put it in an empty directory, and unzip. Then use a browser to open test-coverage.html.

For example, download it here: https://github.com/NOAA-EMC/NCEPLIBS-g2c/actions/runs/7280015917?pr=468

You will see this at the bottom of the page: image

When you unzip and open the top-level file, you will see:

image

If you select a code file, you will see untested lines in red, tested in green: image

Note that code coverage only tells half the story: the code may be run, but if you don't also check the results for correctness, all you've tested is that the code does not crash. In other words, you need to check all the output, as well as make sure all the code is covered.