search

NOAA-EMC / NCEPLIBS-g2c

This library contains C decoder/encoder routines for GRIB edition 2.
Other
18 stars 11 forks source link

Update for g2_gribend.c #479

Closed EricEngle-NOAA closed 8 months ago

EricEngle-NOAA commented 8 months ago

This commit fixes a rare condition in which the last 4 bytes of a packed section 7 could equal "7777" which is the GRIB end of message terminating string and triggers an erroneous end of message status.

The added logic checks for "7777" at the end of cgrib under the condition that we have a valid GRIB message through seciton 7.

This commit references NOAA-EMC/NCEPLIBS-g2c#438

EricEngle-NOAA commented 8 months ago

Well that did go so well. Reworking...

EricEngle-NOAA commented 8 months ago

@edwardhartnett I have come to the conclusion that this we will need more complex code changes to check for this. Let's delete this PR and table to fix for 1.10. Apologies for not making this a draft PR first.