WMO v32 update - Githubissues

NOAA-EMC / NCEPLIBS-g2tmpl

GRIB2 codes and templates

Other

4 stars 9 forks source link

WMO v32 update #107

Closed AndrewBenjamin-NOAA closed 7 months ago

AndrewBenjamin-NOAA commented 9 months ago

Builds off of PR#106:

This PR adds new parameters to g2tmpl, from the v32 WMO grib2 update. In addition, the following new tables were added to params_grib2_tbl_new.text:

4.2-2-6 4.2-4-5 4.2-4-10 4.2-20-0 4.2-20-1 4.2-20-2 4.2-20-3

edwardhartnett commented 9 months ago

These conflicts need to be resolved...

AndrewBenjamin-NOAA commented 9 months ago

These conflicts need to be resolved...

@edwardhartnett which conflicts are you referring to?

edwardhartnett commented 9 months ago

AndrewBenjamin-NOAA commented 9 months ago

@edwardhartnett I don't have write access to resolve the conflicts

AndrewBenjamin-NOAA commented 8 months ago

@edwardhartnett Is there any way to review these conflicts so that this PR can be closed? I cannot view the conflicts to see what needs to be resolved. I cannot resolve them as I am not the reviewer.

edwardhartnett commented 8 months ago

You have to do a git pull on this branch, then open those two files and find and fix the conflicts. Then do a commit of those changes back to the branch.

AndrewBenjamin-NOAA commented 7 months ago

You have to do a git pull on this branch, then open those two files and find and fix the conflicts. Then do a commit of those changes back to the branch.

@edwardhartnett I have resolved the conflicts and committed the changes. We should be all set to proceed.

edwardhartnett commented 7 months ago

OK, this is failing due to an intel problem in the CI due to a change in the way that intel distributes their compiler. I will merge this PR and fix that in a separate PR.

Do we need to do a release now?

AndrewBenjamin-NOAA commented 7 months ago

OK, this is failing due to an intel problem in the CI due to a change in the way that intel distributes their compiler. I will merge this PR and fix that in a separate PR.

Do we need to do a release now?

Yes, we are ready for a release, thank you.

edwardhartnett commented 7 months ago

OK, I don't have a great understanding of this repo, unfortunately, but I believe we have to run some of the fortran programs to take the data from the text files you added to and do something with it.

@jbathegit do you know what has to be done with this repo before a release?

edwardhartnett commented 7 months ago

OK, I have found instructions from Boi in the docs/user_guide.md. (It's not on the docs on the web since he put it in since the last release.)

I'm looking at the instructions now...