search

NOAA-EMC / NCEPLIBS-grib_util

This is a collection of NCEP GRIB related utilities.
Other
19 stars 11 forks source link

code warnings for cnvgrib #130

Closed edwardhartnett closed 6 months ago

edwardhartnett commented 2 years ago 
/home/ed/NCEPLIBS-grib_util/src/cnvgrib/cnv12.F90:65:29:

   65 |   integer :: ideflist(MAXPTS), idefnum
      |                             1
Warning: Array ‘ideflist’ at (1) is larger than limit set by ‘-fmax-stack-var-size=’, moved from stack to static storage. This makes the procedure unsafe when called recursively, or concurrently from multiple threads. Consider increasing the ‘-fmax-stack-var-size=’ limit (or use ‘-frecursive’, which implies unlimited ‘-fmax-stack-var-size’) - or change the code to use an ALLOCATABLE array. If the variable is never accessed concurrently, this warning can be ignored, and the variable could also be declared with the SAVE attribute. [-Wsurprising]

and

[  5%] Building Fortran object src/cnvgrib/CMakeFiles/cnvgrib.dir/cnv22.F90.o
cd /home/ed/NCEPLIBS-grib_util/b/src/cnvgrib && /usr/bin/gfortran  -I/usr/local/NCEPLIBS-g2-3.4.5_bacio-2.5.0/include_4 -I/usr/local/NCEPLIBS-bacio-2.5.0/include -I/usr/include -I/usr/local/NCEPLIBS-w3emc-2.9.2/include_4 -g -g -O0 -Wall -O3 -g -g -O0 -Wall -c /home/ed/NCEPLIBS-grib_util/src/cnvgrib/cnv22.F90 -o CMakeFiles/cnvgrib.dir/cnv22.F90.o
/home/ed/NCEPLIBS-grib_util/src/cnvgrib/cnv22.F90:57:40:

   57 |   logical*1,target,dimension(1) :: dummy
      |                                        1

and 

/home/ed/NCEPLIBS-grib_util/src/cnvgrib/pds2pdtens.F90:37:40:

   37 |      ipdsnum,ipdstmpl,numcoord,coordlist, &
      |                                        1
Warning: Dummy argument ‘coordlist’ at (1) was declared INTENT(OUT) but was not set [-Wunused-dummy-argument]
/home/ed/NCEPLIBS-grib_util/src/cnvgrib/pds2pdtens.F90:36:58:

   36 | subroutine pds2pdtens(kpds,kens,kprob,xprob,kclust,kmember, &
      |                                                          1
Warning: Unused dummy argument ‘kmember’ at (1) [-Wunused-dummy-argument]

and

/home/ed/NCEPLIBS-grib_util/src/cnvgrib/cnv21.F90:26:27:

   26 |   CHARACTER(len=8) :: ctemp
      |                           1
Warning: Unused variable ‘ctemp’ declared at (1) [-Wunused-variable]
/home/ed/NCEPLIBS-grib_util/src/cnvgrib/cnv21.F90:34:40:

   34 |   logical*1,target,dimension(1) :: dummy
      |                                        1
Warning: Unused variable ‘dummy’ declared at (1) [-Wunused-variable]
[ 22%] Building Fortran object src/cnvgrib/CMakeFiles/cnvgrib.dir/cnvgrib.F90.o
cd /home/ed/NCEPLIBS-grib_util/b/src/cnvgrib && /usr/bin/gfortran  -I/usr/local/NCEPLIBS-g2-3.4.5_bacio-2.5.0/include_4 -I/usr/local/NCEPLIBS-bacio-2.5.0/include -I/usr/include -I/usr/local/NCEPLIBS-w3emc-2.9.2/include_4 -g -g -O0 -Wall -O3 -g -g -O0 -Wall -c /home/ed/NCEPLIBS-grib_util/src/cnvgrib/cnvgrib.F90 -o CMakeFiles/cnvgrib.dir/cnvgrib.F90.o
[ 25%] Building Fortran object src/cnvgrib/CMakeFiles/cnvgrib.dir/gdt2gds.F90.o
cd /home/ed/NCEPLIBS-grib_util/b/src/cnvgrib && /usr/bin/gfortran  -I/usr/local/NCEPLIBS-g2-3.4.5_bacio-2.5.0/include_4 -I/usr/local/NCEPLIBS-bacio-2.5.0/include -I/usr/include -I/usr/local/NCEPLIBS-w3emc-2.9.2/include_4 -g -g -O0 -Wall -O3 -g -g -O0 -Wall -c /home/ed/NCEPLIBS-grib_util/src/cnvgrib/gdt2gds.F90 -o CMakeFiles/cnvgrib.dir/gdt2gds.F90.o
[ 27%] Building Fortran object src/cnvgrib/CMakeFiles/cnvgrib.dir/makepds.F90.o
cd /home/ed/NCEPLIBS-grib_util/b/src/cnvgrib && /usr/bin/gfortran  -I/usr/local/NCEPLIBS-g2-3.4.5_bacio-2.5.0/include_4 -I/usr/local/NCEPLIBS-bacio-2.5.0/include -I/usr/include -I/usr/local/NCEPLIBS-w3emc-2.9.2/include_4 -g -g -O0 -Wall -O3 -g -g -O0 -Wall -c /home/ed/NCEPLIBS-grib_util/src/cnvgrib/makepds.F90 -o CMakeFiles/cnvgrib.dir/makepds.F90.o
/home/ed/NCEPLIBS-grib_util/src/cnvgrib/makepds.F90:78:12:

   78 |      idrsnum,idrstmpl,kpds,iret)
      |            1
Warning: Unused dummy argument ‘idrsnum’ at (1) [-Wunused-dummy-argument]
[ 30%] Building Fortran object src/cnvgrib/CMakeFiles/cnvgrib.dir/pds2pdt.F90.o
cd /home/ed/NCEPLIBS-grib_util/b/src/cnvgrib && /usr/bin/gfortran  -I/usr/local/NCEPLIBS-g2-3.4.5_bacio-2.5.0/include_4 -I/usr/local/NCEPLIBS-bacio-2.5.0/include -I/usr/include -I/usr/local/NCEPLIBS-w3emc-2.9.2/include_4 -g -g -O0 -Wall -O3 -g -g -O0 -Wall -c /home/ed/NCEPLIBS-grib_util/src/cnvgrib/pds2pdt.F90 -o CMakeFiles/cnvgrib.dir/pds2pdt.F90.o
/home/ed/NCEPLIBS-grib_util/src/cnvgrib/pds2pdt.F90:35:59:

   35 | subroutine pds2pdt(kpds,ipdsnum,ipdstmpl,numcoord,coordlist, &
      |                                                           1
Warning: Dummy argument ‘coordlist’ at (1) was declared INTENT(OUT) but was not set [-Wunused-dummy-argument]
[ 33%] Building Fortran object src/cnvgrib/CMakeFiles/cnvgrib.dir/setbit.F90.o
cd /home/ed/NCEPLIBS-grib_util/b/src/cnvgrib && /usr/bin/gfortran  -I/usr/local/NCEPLIBS-g2-3.4.5_bacio-2.5.0/include_4 -I/usr/local/NCEPLIBS-bacio-2.5.0/include -I/usr/include -I/usr/local/NCEPLIBS-w3emc-2.9.2/include_4 -g -g -O0 -Wall -O3 -g -g -O0 -Wall -c /home/ed/NCEPLIBS-grib_util/src/cnvgrib/setbit.F90 -o CMakeFiles/cnvgrib.dir/setbit.F90.o
/home/ed/NCEPLIBS-grib_util/src/cnvgrib/setbit.F90:66:5:

   66 | NBIT=LOG((GMAX-GMIN)*S+0.9)/LOG(2.)+1.
      |     1
Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1) [-Wconversion]
edwardhartnett commented 6 months ago

At least for now, we are not going to work on GRIB1 any longer unless absolutely necessary.