NOAA-EMC / NCEPLIBS-grib_util

This is a collection of NCEP GRIB related utilities.
Other
19 stars 11 forks source link

now testing with g2c_compare utility #201

Closed edwardhartnett closed 1 year ago

edwardhartnett commented 1 year ago

Part of #184.

I've introduced a new utility program in the g2c project: g2c_compare.

This utility can be used to compare outputs to ensure correctness, but without caring about what the exact offsets are. In this way, it can identify two GRIB2 files as the same, even if different versions of jasper were used, and the compressed data are different.

edwardhartnett commented 1 year ago

OK, the problem was that we could not reliably test GRIB2 files for equality, because changing the jasper version can change the values in both degrib2 output and grb2index output. So how to do this?

I have introduced a new utility for testing called g2c_compare in the g2c library. It compares two files and different jasper versions don't matter.

So with this new utility we can test for multiple jasper versions, which I do in the CI, which now tests more combinations of versions, both our own packages and jasper.

edwardhartnett commented 1 year ago

@AlexanderRichert-NOAA and @Hang-Lei-NOAA if we can get this reviewed and merged, I think that will allow me to merge @GeorgeGayno-NOAA 's PR #203