search

NOAA-EMC / NCEPLIBS-grib_util

This is a collection of NCEP GRIB related utilities.
Other
21 stars 11 forks source link

Support ip 4.x #237

Closed AlexanderRichert-NOAA closed 1 year ago

AlexanderRichert-NOAA commented 1 year ago

I am unable to get grib_util 1.2.4 to compile with ip v4. Let me know if you think there's anything about the ip library that needs to change. Here is some of the output when I try to compile grib-util 1.2.4 with ip 4.1.0 through spack-stack.

     165    CMakeFiles/copygb.dir/copygb.F90.o: In function `MAIN__':
  >> 166    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:257: undefined reference to `makgds_'
     167    CMakeFiles/copygb.dir/copygb.F90.o: In function `intgrib1':
  >> 168    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1249: undefined reference to `ipolates_'
  >> 169    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1326: undefined reference to `ipolatev_'
  >> 170    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1296: undefined reference to `ipolatev_'
  >> 171    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1285: undefined reference to `ipolatev_'
  >> 172    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1264: undefined reference to `ipolatev_'
  >> 173    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1227: undefined reference to `ipolates_'
  >> 174    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1221: undefined reference to `ipolates_'
  >> 175    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1208: undefined reference to `ipolates_'
     176    CMakeFiles/copygb.dir/copygb.F90.o: In function `intgrib1_':
  >> 177    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1249: undefined reference to `ipolates_'
  >> 178    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1326: undefined reference to `ipolatev_'
  >> 179    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1221: undefined reference to `ipolates_'
  >> 180    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1285: undefined reference to `ipolatev_'
  >> 181    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1296: undefined reference to `ipolatev_'
  >> 182    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1227: undefined reference to `ipolates_'
  >> 183    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1264: undefined reference to `ipolatev_'
  >> 184    /work/noaa/nems/arichert/spack-stack-ip-4.1.0/envs/test/grib-util/src/copygb/copygb.F90:1208: undefined reference to `ipolates_'

This issue is related to https://github.com/NOAA-EMC/UPP/issues/741 (moving UPP to ip 4.1.0)

edwardhartnett commented 1 year ago

@AlexanderRichert-NOAA do you know what has to be done to the code in order to support ip-4.0.0?

I am soon going to do a release of grib_util, so if we can get this in soon, that would be great.

AlexanderRichert-NOAA commented 1 year ago

I can get it to build (haven't tested running it) by adding "use ip_mod" to the "INTGRIB1" subroutines in src/copygb/copygb.F90 and src/copygb2/copygb2.F90

edwardhartnett commented 1 year ago

OK, but other than degrib2, I'm not sure we have very good testing. So wherever you need to make changes, first make sure there is a test.

On Thu, Jul 20, 2023 at 11:05 AM Alex Richert @.***> wrote:

I can get it to build (haven't tested running it) by adding "use ip_mod" to the "INTGRIB1" subroutines in src/copygb/copygb.F90 and src/copygb2/copygb2.F90

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NCEPLIBS-grib_util/issues/237#issuecomment-1644281758, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJIOMMGFYQSV63S6E53NTJTXRFQNFANCNFSM6AAAAAA2OZV57U . You are receiving this because you were assigned.Message ID: @.***>

-- Edward Hartnett CIRES/NOAA EMC

AlexanderRichert-NOAA commented 1 year ago

Duplicate of #93