search

NOAA-EMC / NCEPLIBS-grib_util

This is a collection of NCEP GRIB related utilities.
Other
19 stars 11 forks source link

Update copygb, copygb2 testing #242

Closed AlexanderRichert-NOAA closed 1 year ago

AlexanderRichert-NOAA commented 1 year ago

Extend/reinstate copygb+copygb2 testing to include interp functionality. Move to ip 4.x.

Fixes #93 Addresses #116

AlexanderRichert-NOAA commented 1 year ago

wgrib output of 172.land.grib1 from copygb when using w3emc 2.9.3:

rec 1:0:date 2022122000 LAND kpds5=81 kpds6=1 kpds7=0 levels=(0,0) grid=172 sfc 24hr fcst:
  LAND=Land cover (land=1;sea=0) [fraction]
  timerange 10 P1 0 P2 24 TimeU 1  nx 690 ny 710 GDS grid 5 num_in_ave 0 missing 0
  center 7 subcenter 0 process 96 Table 2 scan: WE:SN winds(N/S) 
  polar stereo: Lat1 -36.866000 Long1 -220.194000 Orient -260.000000
     south pole (690 x 710) Dx 12700 Dy 12700 scan 64 mode 0
  min/max data 0 1  num bits 1  BDS_Ref 0  DecScale 0 BinScale 0

wgrib output of 172.land.grib1 from copygb when using w3emc 2.10.0:

rec 1:0:date 2022122000 LAND kpds5=81 kpds6=1 kpds7=0 levels=(0,0) grid=172 sfc 24hr fcst:
  LAND=Land cover (land=1;sea=0) [fraction]
  timerange 10 P1 0 P2 24 TimeU 1  nx 690 ny 710 GDS grid 5 num_in_ave 0 missing 0
  center 7 subcenter 0 process 96 Table 2 scan: WE:SN winds(N/S) 
  polar stereo: Lat1 -36.899000 Long1 -220.194000 Orient -80.000000
     south pole (690 x 710) Dx 12700 Dy 12700 scan 64 mode 0
  min/max data 0 1  num bits 1  BDS_Ref 0  DecScale 0 BinScale 0
AlexanderRichert-NOAA commented 1 year ago

@edwardhartnett per my above comment, when copygb regrids an input file, it gives different results for one of the test files depending on which version of w3emc is used. Note the differences for 'Lat1' and 'Orient'. Does this indicate that one or the other version of w3emc is doing something wrong, or does this come down to different valid choices that can be made in the regridding process?

edwardhartnett commented 1 year ago

@GeorgeGayno-NOAA do you know the answer to @AlexanderRichert-NOAA 's question? I sure don't...

GeorgeGayno-NOAA commented 1 year ago

@edwardhartnett per my above comment, when copygb regrids an input file, it gives different results for one of the test files depending on which version of w3emc is used. Note the differences for 'Lat1' and 'Orient'. Does this indicate that one or the other version of w3emc is doing something wrong, or does this come down to different valid choices that can be made in the regridding process?

The definition of grids 172 and 220 was updated. https://github.com/NOAA-EMC/NCEPLIBS-w3emc/issues/157

edwardhartnett commented 1 year ago

OK, so it looks like we want to change the test to accept the answer from the current version of w3emc, and we can stop testing with older versions.

We should also change the grib_util main cmake file so that it requires the latest release of w3emc.