search

NOAA-EMC / NCEPLIBS-ip

Fortran 90 subprograms to be used for interpolating between nearly all grids used at NCEP.
Other
5 stars 9 forks source link

Implement v3.0.2 #11

Closed GeorgeGayno-NOAA closed 3 years ago

GeorgeGayno-NOAA commented 4 years ago

GFS v16 requires v3.0.2. The v3.0.2 tag has old release notes. Update the notes and make any other required changes.

Following the Gitflow method, a support branch will be created from the v3.0.2 tag. Once the branch is working, I can recreate the v3.0.2 tag.

GeorgeGayno-NOAA commented 4 years ago

NCO requested a Cray/haswell version for Cray. Dexin's build system does not support that compiler. Also, I noticed the openmp flag is not being used. Make these updates.

Hang-Lei-NOAA commented 4 years ago

Thanks George for the updates.

On Thu, Aug 6, 2020 at 9:00 AM GeorgeGayno-NOAA notifications@github.com wrote:

NCO requested a Cray/haswell version for Cray. Dexin's build system does not support that compiler. Also, I noticed the openmp flag is not being used. Make these updates.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NCEPLIBS-ip/issues/11#issuecomment-669911347, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKWSMFH5YZ5ZBA2YPBF3COLR7KSNFANCNFSM4N3TX57Q .

kgerheiser commented 4 years ago

Is this necessary for all libraries?

Hang-Lei-NOAA commented 4 years ago

I would think that may not be, since we will push cmake after this code delivery to NCO.

On Thu, Aug 6, 2020 at 10:00 AM Kyle Gerheiser notifications@github.com wrote:

Is this necessary for all libraries?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NCEPLIBS-ip/issues/11#issuecomment-669944669, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKWSMFFWFOUYAWFOQAXLFZLR7KZN3ANCNFSM4N3TX57Q .

GeorgeGayno-NOAA commented 4 years ago

The include files for calling the library from 'c' code were removed for some reason. Add those back. These missing files would have been caught if the unit and regression tests were run before merging. However, these tests were never updated for the new build system and are not able to be compiled. I will use the tests from v3.0.1 to verify everything is working.

kgerheiser commented 4 years ago

I'll work on adding the regression tests to CMake

GeorgeGayno-NOAA commented 4 years ago

I'll work on adding the regression tests to CMake

Thanks. I thought you already added the tests for some libraries.

GeorgeGayno-NOAA commented 4 years ago

I ran the two unit tests on Dell (tests at c2db5e0) using the library/include files from the support branch at 74d5e84. Both passed. Will recreate the tag for NCO.

Also ran the unit test on Cray using the Cray build of the library. It passed.

kgerheiser commented 4 years ago

I have a question. Why are all of your commits the same, like "support/ip_v3.0.2 This commit references #11? Do you use some tool for git that does this?

I see now, there's a little box that expands with the commit

GeorgeGayno-NOAA commented 4 years ago

~I have a question. Why are all of your commits the same, like "support/ip_v3.0.2 This commit references #11? Do you use some tool for git that does this?~

I see now, there's a little box that expands with the commit

It is just how I like to start the commit message. It helps me remember what branch I am working from. And the commit gets tagged to the issue. Maybe there is a better or official github way to write the commit messages.

edwardhartnett commented 3 years ago

This is complete, correct?

GeorgeGayno-NOAA commented 3 years ago

This is complete, correct?

Yes, you can close it.