search

NOAA-EMC / NCEPLIBS-ip2

Other
1 stars 4 forks source link

CMake build for ip2 #5

Closed kgerheiser closed 4 years ago

kgerheiser commented 4 years ago

Is there a version for this library? I put 1.0.0, because I couldn't find one.

GeorgeGayno-NOAA commented 4 years ago

Is there a version for this library? I put 1.0.0, because I couldn't find one.

Version 1.0.0 was tagged and implemented on WCOSS a while back. So we should increase the version number.

kgerheiser commented 4 years ago

I bumped the version number and I removed the make build system

kgerheiser commented 4 years ago

@GeorgeGayno-NOAA

I added the updated lat-lon thing. Let me know if this is right.

https://github.com/kgerheiser/NCEPLIBS-ip2/blob/feature/cmake/src/gdswzd_rot_equid_cylind_egrid_mod.f90

GeorgeGayno-NOAA commented 4 years ago

@GeorgeGayno-NOAA

I added the updated lat-lon thing. Let me know if this is right.

https://github.com/kgerheiser/NCEPLIBS-ip2/blob/feature/cmake/src/gdswzd_rot_equid_cylind_egrid_mod.f90

Looks like you got the correct version. Before merging I would like to run my unit and regression tests. Unfortunately, they ceased to work when Dexin added his build system. So I will use the tests from a previous snap shot.

GeorgeGayno-NOAA commented 4 years ago

We store 'iplib.sh' files in the include directory. Can that file be added as part of the install?

kgerheiser commented 4 years ago

You mean iplib_4.h, etc (not .sh)?

GeorgeGayno-NOAA commented 4 years ago

You mean iplib_4.h, etc (not .sh)?

Yes. And they are all stored with the same name - iplib.h. On Dell...

m71a1@ /gpfs/dell1/nco/ops/nwprod/lib/ip2/v1.0.0/ips/18.0.1\ $ ls -lR include/*/*.h
-rwxr-xr-x 1 nwprod prod 325 Aug  2  2019 include/ip2_v1.0.0_4/iplib.h
-rwxr-xr-x 1 nwprod prod 343 Aug  2  2019 include/ip2_v1.0.0_8/iplib.h
-rwxr-xr-x 1 nwprod prod 337 Aug  2  2019 include/ip2_v1.0.0_d/iplib.h
kgerheiser commented 4 years ago

Ok, that's easy.

kgerheiser commented 4 years ago

Done

It installs iplib_${kind} as iplib.h for each kind

GeorgeGayno-NOAA commented 4 years ago

How different really is ip2 from up and if not very, why are they not a single library? I see a lot of repeated code between ip and ip2.

They are very similar. ip2 does its geo-references using the grib2 grid definition template, while ip uses the grib1 template. The grib2 template has more information. But in principle they could be combined.

GeorgeGayno-NOAA commented 4 years ago

Should threading be turned on by default? That is how we normally compile ip/ip2.

GeorgeGayno-NOAA commented 4 years ago

Checked out 5d6821f on Dell (which contains the last fully working version of the unit and regression tests). Ran all tests using Kyle's branch at 001e181. All tests passed. Yeah!

GeorgeGayno-NOAA commented 4 years ago

@kgerheiser At some point, we need to get the unit and regression tests working. I don't know if you want to do that with this pull request or wait.

kgerheiser commented 4 years ago

Fixed all those things. Good to merge then?