NOAA-EMC / NCEPLIBS-ncio

This is a NOAA library used by NCEP GSI system to read the GFS forecast files for use in data assimilation.
Other
1 stars 6 forks source link

Add test to read new 5D variable #46

Closed CoryMartin-NOAA closed 3 years ago

CoryMartin-NOAA commented 3 years ago

Closes issue #43

Adds test to read 5D variable, newly added to the test input data. This input data also was modified to have real (non fill) values for pressfc and vgrd so that the initial read_vardata tests can be confirmed with proper min and max value checks.

Note: this does make the test input file a lot larger, but this is because the original actually didn't have any data in it. I feel like that the increase in size is worth having real values to read/check against.

edwardhartnett commented 3 years ago

Since you are creating the test file during your test, it can be as large as you need it to be. ;-)

CoryMartin-NOAA commented 3 years ago

@edwardhartnett no I'm referring to the input reference file that is already in the repo. It went from like 100KB to 4MB. Still 'small' relatively speaking.