search

NOAA-EMC / NCEPLIBS-ncio

This is a NOAA library used by NCEP GSI system to read the GFS forecast files for use in data assimilation.
Other
1 stars 6 forks source link

fix for new 'time_iso' variable in GFS history files #53

Closed jswhit closed 2 years ago

jswhit commented 2 years ago

https://github.com/ufs-community/ufs-weather-model/issues/1052 added a new 'time_iso' character array variable in the GFS history files. This PR fixes NCEPLIBS-ncio so it correctly handles this variable. Without this fix, the netcdf library will exit with 'NetCDF start count exceeds dimension bound' error code. The fix involves always passing start and count arrays to nf90_put_var and nf90_get_var since the failure only occurs when these optional arguments are not given and the fortran interface infers them from the variable dimensions. The tests have also been updated.

@CoryMartin-NOAA

jswhit commented 2 years ago

the macosx CI test fails when building netcdf-fortran, because the library "-lzip" is not found. Don't know how to fix this.

kgerheiser commented 2 years ago

I'll take a look

aerorahul commented 2 years ago

Can we get a move on this PR? The fix in this PR is required in several DA related utilities required for cycling with the latest UFS-weather-model.

kgerheiser commented 2 years ago

55 should fix the automated build, and then if you could update your PR with those changes this can be merged.

kgerheiser commented 2 years ago

@jswhit can you remove the changes to the workflow action?

jswhit commented 2 years ago

@jswhit can you remove the changes to the workflow action?

Done