search

NOAA-EMC / NCEPLIBS-ncio

This is a NOAA library used by NCEP GSI system to read the GFS forecast files for use in data assimilation.
Other
1 stars 6 forks source link

Create 1.1.2 release for time_iso variable addition and fixes to both read_vardata_code_1d and write_vardata_code #64

Closed MichaelLueken closed 2 years ago

MichaelLueken commented 2 years ago

@kgerheiser @Hang-Lei-NOAA @edwardhartnett Would it be possible to create a new 1.1.1 or 1.1.2 release for NCEPLIBS-ncio and have this version propagated through the stack? While the update in ncio/1.1.1 does correct issues encountered in getsfcensmeanp, as well as corrects issues while dealing with the increment, it leads to failures in the analysis due to write_varadata_code. The latest update, 95a0d9b, contains changes that will allow the GSI to run in full analysis mode without issue.

I would be greatly appreciative if you could create a new release from this version and build it in the stack on the various machines.

Thank you very much for your time.

Hang-Lei-NOAA commented 2 years ago

We will do it soon.

Hang-Lei-NOAA commented 2 years ago

@MichaelLueken-NOAA Are you sure that this fix has solved all the issues?

MichaelLueken commented 2 years ago

@Hang-Lei-NOAA I have applied the change to my stack built ncio library and was able to test both the increment mode (the read_vardata_code_1d fix) and full analysis mode (the write_vardata_code fix) and both behaved as expected. All issues, that I'm aware of, should now be corrected.

Hang-Lei-NOAA commented 2 years ago

@Michael Lueken - NOAA Affiliate @.***> Thanks Michael!

On Tue, Jun 14, 2022 at 9:53 AM MichaelLueken-NOAA @.***> wrote:

@Hang-Lei-NOAA https://github.com/Hang-Lei-NOAA I have applied the change to my stack built ncio library and was able to test both the increment mode (the read_vardata_code_1d fix) and full analysis mode (the write_vardata_code fix) and both behaved as expected. All issues, that I'm aware of, should now be corrected.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NCEPLIBS-ncio/issues/64#issuecomment-1155217072, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKWSMFDUYWYVUMMBJZBS5B3VPCFDXANCNFSM5YXALDPA . You are receiving this because you were mentioned.Message ID: @.***>

MichaelLueken commented 2 years ago

@Hang-Lei-NOAA Thank you very much for creating the v1.1.2 tag! I will update the existing hpc-stack issue (#462) for the installation of this version of the library on the various machines. I will also close this issue now.