search

NOAA-EMC / NCEPLIBS-w3emc

This library contains Fortran 77 decoder/encoder routines for GRIB edition 1.
Other
2 stars 8 forks source link

Eliminate calls to some mystery subroutines #223

Closed AlexanderRichert-NOAA closed 5 months ago

AlexanderRichert-NOAA commented 5 months ago

This PR reduces the number of undefined subroutines, most importantly, the ones in w3as00.f since that actually gets used in grib_util. The remaining ones use subroutines that haven't existed for decades (either long-deprecated NCEP routines or fortran intrinsics that don't exist in gfortran/ifort/ifx). (aside: consol() comes from a now-nonexistent library called GPH, and dbn_alert() was in the old w3lib circa the early 2000s). I'm proposing we remove those remaining subroutines because there's no way anyone could be using them at this point.

Also includes an update the spack package to get rid of annoying variant-dependent variant.

Tested with grib-util unit tests to ensure w3as00 still works (used by tocgrib).

Fixes #224 Fixes https://github.com/NOAA-EMC/NCEPLIBS-grib_util/issues/280

AlexanderRichert-NOAA commented 5 months ago

I've confirmed that the subroutines being removed are not used in operational executables, both based on checking the source code and, more importantly, checking the compiled executables themselves.