search

NOAA-EMC / NCEPLIBS

Top level repo containing submodules for NCEPLIBS and associated dependencies for superproject builds
Other
42 stars 18 forks source link

Update chgres to latest develop #21

Closed jedwards4b closed 4 years ago

jedwards4b commented 4 years ago

Please see https://github.com/ufs-community/ufs-mrweather-app/issues/58#issuecomment-574454266 Can you please test the latest chgres_cube from develop and if it works merge it to ufs_public_release_v1.0?

jedwards4b commented 4 years ago

@climbfuji I tried to do this myself but the cmake interfaces were removed from the develop branch, so I tried to merge ufs_release_v1.0 into develop but that isn't working either.

climbfuji commented 4 years ago

Sounds like we need to do a manual update of ufs_release_v1.0 with those changes. @GeorgeVandenberghe-NOAA is it correct that you made the updates to "develop"? Would you be able to make the same updates to "ufs_release_v1.0" that fix the chgres_cube problem?

GeorgeVandenberghe-NOAA commented 4 years ago

I suspect it's George Gayno who maintains chgres. Not sure what changes we are talking about. I did make changes in the build to get rid of machine dependencies but never committed them

On Friday, January 17, 2020, Dom Heinzeller notifications@github.com wrote:

Sounds like we need to do a manual update of ufs_release_v1.0 with those changes. @GeorgeVandenberghe-NOAA https://github.com/GeorgeVandenberghe-NOAA is it correct that you made the updates to "develop"? Would you be able to make the same updates to "ufs_release_v1.0" that fix the chgres_cube problem?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NCEPLIBS/issues/21?email_source=notifications&email_token=ANDS4FWUSECDYZADZ7LPWJTQ6JYG5A5CNFSM4KHX52IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJJPEEI#issuecomment-575861265, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANDS4FUKQGW5CUJUA6KLDCLQ6JYG5ANCNFSM4KHX52IA .

climbfuji commented 4 years ago

I suspect it's George Gayno who maintains chgres. Not sure what changes we are talking about. I did make changes in the build to get rid of machine dependencies but never committed them …

I am sorry. Still confused who is doing what at the East Coast ... @GeorgeGayno-NOAA would you be able to make the same updates to "ufs_release_v1.0" that you made to "develop" to fix the chgres_cube problem for the UFS public release? It seems that the codebases are different enough to prohibit merging. Thank you!

jedwards4b commented 4 years ago

I have submitted PR https://github.com/NOAA-EMC/UFS_UTILS/pull/45 with this change in chgres_cube.

climbfuji commented 4 years ago

@jedwards4b I will wait for @GeorgeGayno-NOAA to approve, then I can merge it and update the submodule pointer in the umbrella build. Thanks!

climbfuji commented 4 years ago

Merged.