Remove nems grid comp - Githubissues

NOAA-EMC / NEMS

NEMS (NOAA Environmental Modeling System)

https://noaa-emc.github.io/NEMS_doc/index.html

Other

11 stars 46 forks source link

Remove nems grid comp #104

Closed DusanJovic-NOAA closed 3 years ago

DusanJovic-NOAA commented 3 years ago

Remove NEMS grid component. The Earth grid component is now instantiated in the main program.
Remove import/export stated from the main program.
Code cleanup.

Fixes: #103

DeniseWorthen commented 3 years ago

Would it be possible to remove the ALLCAPS and just use lower case where possible? (eg INTEGER,INTENT(OUT) :: RC_REG)

DusanJovic-NOAA commented 3 years ago

Would it be possible to remove the ALLCAPS and just use lower case where possible? (eg INTEGER,INTENT(OUT) :: RC_REG)

Do you mean in module_EARTH_GRID_COMP.F90?

BTW, I think this file (module) should be renamed to ufs_nuopc_driver.F90 because that's what it is.

DeniseWorthen commented 3 years ago

Would it be possible to remove the ALLCAPS and just use lower case where possible? (eg INTEGER,INTENT(OUT) :: RC_REG)

Do you mean in module_EARTH_GRID_COMP.F90?

BTW, I think this file (module) should be renamed to ufs_nuopc_driver.F90 because that's what it is.

Yes, in the earth grid, I was referring to the code itself where it is written in all caps, for example

      PRIVATE
!
      PUBLIC :: EARTH_REGISTER
      PUBLIC :: VERBOSE_DIAGNOSTICS

MinsukJi-NOAA commented 3 years ago

@junwang-noaa @DeniseWorthen please review and approve