search

NOAA-EMC / NEMS

NEMS (NOAA Environmental Modeling System)
https://noaa-emc.github.io/NEMS_doc/index.html
Other
11 stars 46 forks source link

Add data ocean support and add support for reading modelio:: attribute group ... #106

Closed uturuncoglu closed 2 years ago

uturuncoglu commented 3 years ago

This PR aims to bring data ocean support to NEMS, which is related to the issue https://github.com/NOAA-EMC/NEMS/issues/107. It also includes fix for reading modelio attributes from nems.configure and passing it to the CDEPS and CMEPS in case of it is defined.

MinsukJi-NOAA commented 3 years ago

I ran UFS-weather-model regression tests with this NEMS changes on Hera. All gnu passed. All intel passed except for control_atm_aerosols, which resulted in MPI_Abort. Tried it 4 times and all failed. Can any one try this test case on Hera and verify?

uturuncoglu commented 3 years ago

@MinsukJi-NOAA i am not sure but this could be an issue related with recently added GOCART chemistry component.

junwang-noaa commented 3 years ago

@MinsukJi-NOAA where is your RT run directory with the failed control_atm_aerosols test?

MinsukJi-NOAA commented 3 years ago

@MinsukJi-NOAA where is your RT run directory with the failed control_atm_aerosols test?

LOGDIR: /scratch2/NCEPDEV/stmp1/Minsuk.Ji/ufs-weather-model/tests/log_hera.intel

RUNDIR: /scratch1/NCEPDEV/stmp2/Minsuk.Ji/FV3_RT/rt_64975/control_atm_aerosols

DeniseWorthen commented 3 years ago

The PET000 log shows PET000 module_EARTH_GRID_COMP.F90:453 Not valid - No component gocart found. I think the branch needs to be updated w/ the current head of NEMS.

MinsukJi-NOAA commented 3 years ago

The PET000 log shows PET000 module_EARTH_GRID_COMP.F90:453 Not valid - No component gocart found. I think the branch needs to be updated w/ the current head of NEMS.

I think you are right. #102 was merged in after this PR was submitted.

junwang-noaa commented 3 years ago

Yes, there is no gocart in module_EARTH_GRID_COMP.F90. @uturuncoglu please merge with the latest nems develop branch.

[Jun.Wang@hfe11 src]$ grep -i "gocart" module_EARTH_GRID_COMP.F90 [Jun.Wang@hfe11 src]$

BinLiu-NOAA commented 3 years ago

@junwang-noaa @MinsukJi-NOAA @DeniseWorthen @uturuncoglu, I have just synced this feature/hafs_couplehycom_cdeps branch with the latest develop branch.

MinsukJi-NOAA commented 3 years ago

control_atm_aerosols regression test passed. This PR is good for merge into UFS-weather-model @junwang-noaa @DeniseWorthen

junwang-noaa commented 3 years ago

@DeniseWorthen https://github.com/DeniseWorthen can we merge this PR with your ufs-weather-model PR #639?

On Fri, Jul 16, 2021 at 9:05 AM Minsuk Ji @.***> wrote:

control_atm_aerosols regression test passed. This PR is good for merge into UFS-weather-model @junwang-noaa https://github.com/junwang-noaa @DeniseWorthen https://github.com/DeniseWorthen

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/106#issuecomment-881433851, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7D6TKEYGFAUPF2YZ5GPALTYAU7ZANCNFSM47RA5HOQ .

DeniseWorthen commented 3 years ago

Yes that would be fine. I will switch my .gitmodules to point to the PR branch.

MinsukJi-NOAA commented 3 years ago

@BinLiu-NOAA #104 is expected to be merged in today. Please update the feature/hafs_couplehycom_cdeps branch once again after that since this PR is scheduled for early next week.

BinLiu-NOAA commented 3 years ago

@BinLiu-NOAA #104 is expected to be merged in today. Please update the feature/hafs_couplehycom_cdeps branch once again after that since this PR is scheduled for early next week.

Will do. Thanks @MinsukJi-NOAA!

DeniseWorthen commented 3 years ago

@BinLiu-NOAA Could you please update to the NEMS commit from today? Thanks.

BinLiu-NOAA commented 3 years ago

@MinsukJi-NOAA @DeniseWorthen, have just synced with the latest develop branch as of this afternoon (07/16/2021). Thanks!