NOAA-EMC / NEMS

NEMS (NOAA Environmental Modeling System)
https://noaa-emc.github.io/NEMS_doc/index.html
Other
11 stars 46 forks source link

Feature/changefldnames #29

Closed DeniseWorthen closed 4 years ago

DeniseWorthen commented 4 years ago

Updates for issue #28 issue #27 issue #26 Issue #30

The Atm/Ocn flux fields on atm grid have also been commented out in the prep_atm mediator phase since they are not used.

For the coupled model, this PR requires matching CICE and FV3 commits and the baselines will change due to the removal of the mediator fluxes in prep_ocn. Otherwise no baseline changes are expected.

The ability to build the CMEPS mediator is added to the module_EARTH_GRID_COMP.F90. Required build-related files are added.

MinsukJi-NOAA commented 4 years ago

Denise, Do these changes affect s2s-model only? Do we need regression test results?

DeniseWorthen commented 4 years ago

Minsuk,

These should not affect the standalone. Jun or Ratko could advise whether you need to test ufs-weather.

RatkoVasic-NOAA commented 4 years ago

Minsuk,

These should not affect the standalone. Jun or Ratko could advise whether you need to test ufs-weather.

Minsuk, I suggest you run the ufs-weather test on Hera, just to make sure that nothing is broken.

MinsukJi-NOAA commented 4 years ago

Ufs-weather-model regression tests passed on hera: RegressionTests_hera.intel.log

Minsuk, These should not affect the standalone. Jun or Ratko could advise whether you need to test ufs-weather.

Minsuk, I suggest you run the ufs-weather test on Hera, just to make sure that nothing is broken.

MinsukJi-NOAA commented 4 years ago

Ufs-s2s-model regression tests passed on hera:

rtreport.txt

MinsukJi-NOAA commented 4 years ago

Re-ran ufs-weather-model RT on hera due to additional changes (CMEPS mediator build capability). All tests passed. RegressionTests_hera.intel.log