search

NOAA-EMC / NEMS

NEMS (NOAA Environmental Modeling System)
https://noaa-emc.github.io/NEMS_doc/index.html
Other
11 stars 46 forks source link

NEMSCompsetRun bug fix: pass --label to srun (requires produtil PR) #47

Closed SamuelTrahanNOAA closed 4 years ago

SamuelTrahanNOAA commented 4 years ago

The NEMSCompsetRun was asking produtil to pass the --label option, but that request was ignored since produtil.mpi_impl.srun_shell ignored the label_io=True option. This NCEPLIBS-pyprodutil PR fixes the bug in produtil. The submodule at the NEMS level must be updated as well:

MinsukJi-NOAA commented 4 years ago

@SamuelTrahanNOAA , can you please update this PR to include the latest NEMS and NCEPLIBS-pyprodutil changes? Thanks!

SamuelTrahanNOAA commented 4 years ago

@SamuelTrahanNOAA , can you please update this PR to include the latest NEMS and NCEPLIBS-pyprodutil changes? Thanks!

I merged the changes and I'm testing them now on Hera.

SamuelTrahanNOAA commented 4 years ago

@MinsukJi-NOAA The deed is done. I've merged the latest NEMS develop. I re-ran NEMSCompsetRun for the ufs-weather-model: all tests passed and the log file had the MPI rank at the beginning of each line.

MinsukJi-NOAA commented 4 years ago

@MinsukJi-NOAA The deed is done. I've merged the latest NEMS develop. I re-ran NEMSCompsetRun for the ufs-weather-model: all tests passed and the log file had the MPI rank at the beginning of each line.

Thanks! Merged the PR.