Closed aerorahul closed 4 years ago
The changes are good, NEMS code manager Minsuk will do a final check and he can commit the code. On ufs-weather-model side, @DusanJovic-NOAA, do you think we can combine this with Tom's commit?
On Mon, Apr 6, 2020 at 8:39 AM Dusan Jovic notifications@github.com wrote:
@DusanJovic-NOAA approved this pull request.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/49#pullrequestreview-388207546, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7D6TNS7K6WN2J7BAJJVV3RLHEPLANCNFSM4L432P2Q .
All regression test log files for Tom's commit are already uploaded. If we ask him to update NEMS we'll need to rerun full tests on all platforms.
I thought Tom made code changes following Rusty's suggestion in code review.
On Mon, Apr 6, 2020 at 10:21 AM Dusan Jovic notifications@github.com wrote:
All regression test log files for Tom's commit are already uploaded. If we ask him to update NEMS we'll need to rerun full tests on all platforms.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/49#issuecomment-609825024, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7D6TMRRL2BPHAH2MEIOH3RLHQN3ANCNFSM4L432P2Q .
I didn't see any commits made to https://github.com/TomBlack-NOAA/GFDL_atmos_cubed_sphere/tree/blend_DA
Build NEMS on SSEC University of Wisconsin S4 supercomputer.
See corresponding UFS PR #98