NOAA-EMC / NEMS

NEMS (NOAA Environmental Modeling System)
https://noaa-emc.github.io/NEMS_doc/index.html
Other
11 stars 46 forks source link

production/GFS.v16: update module initialization script #70

Closed junwang-noaa closed 4 years ago

junwang-noaa commented 4 years ago

Orion platform is added to module_setup script to allow that module files are properly purged on Orion.

MinsukJi-NOAA commented 4 years ago

When I made the similar changes for the S2S model, the path was /apps/lmod/init/$__ms_shell. I just checked on Orion, and it looks like this has been updated on Jun 22 to /apps/lmod/lmod/init/$__ms_shell.

junwang-noaa commented 4 years ago

Minsuk,

This change should be made in NEMS, I am curious how you make it in s2s model. I see the changes were made in NEMS develop branch. This PR is for NEMS production/GFS.v16 branch, which is used for GFSv16 implementation.

On Thu, Jun 25, 2020 at 1:54 PM Minsuk Ji notifications@github.com wrote:

When I made the similar changes for the S2S model, the path was /apps/lmod/init/$__ms_shell. I just checked on Orion, and it looks like this has been updated on Jun 22 to /apps/lmod/lmod/init/$__ms_shell.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/70#issuecomment-649730369, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7D6TIUNZDHCUDVBUIGXK3RYOFMZANCNFSM4OIS5KBA .

MinsukJi-NOAA commented 4 years ago

Sorry, I meant the NEMS develop branch. Can we double check on the path on Orion?

junwang-noaa commented 4 years ago

That's weird, I remember I checked the path when I made this update, I first tried hera's path, which is /apps/lmod/lmod/init, but that path does not exist, so I changed /apps/lmod/init. Now I do see /apps/lmod/lmod/init exist, but /apps/lmod/init does not exist. Will change back.

On Thu, Jun 25, 2020 at 2:14 PM Minsuk Ji notifications@github.com wrote:

@MinsukJi-NOAA commented on this pull request.

In src/conf/module-setup.csh.inc https://github.com/NOAA-EMC/NEMS/pull/70#discussion_r445746774:

@@ -14,6 +14,12 @@ else if ( { test -d /scratch1 -a ! -d /scratch } ) then source /apps/lmod/lmod/init/$__ms_shell endif module purge +else if ( { test -d /work/noaa } ) then

  • We are on Orion

  • if ( ! { module help >& /dev/null } ) then
  • source /apps/lmod/init/$__ms_shell

should this be /apps/lmod/lmod/init/$__ms_shell

In src/conf/module-setup.sh.inc https://github.com/NOAA-EMC/NEMS/pull/70#discussion_r445747151:

@@ -28,6 +28,12 @@ elif [[ -d /scratch1 && ! -d /scratch ]] ; then source /apps/lmod/lmod/init/$__ms_shell fi module purge +elif [[ -d /work/noaa ]] ; then

  • We are on Orion

  • if ( ! eval module help > /dev/null 2>&1 ) ; then
  • source /apps/lmod/init/$__ms_shell

Similarly here, /apps/lmod/lmod/init

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/70#pullrequestreview-437741696, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7D6TOPC2Z7SKY45DNVHNLRYOHYLANCNFSM4OIS5KBA .

MinsukJi-NOAA commented 4 years ago

Yeah, I can confirm that it was /apps/lmod/init :)

junwang-noaa commented 4 years ago

They must be changed during Orion maintenance, the directory is changed on 6/22

Orion-login-2[129] junwang$ ls -l /apps/lmod total 0 drwxr-xr-x 11 root root 176 Jun 22 15:35 8.3.17 lrwxrwxrwx 1 root root 6 Jun 22 15:35 lmod -> 8.3.17

On Thu, Jun 25, 2020 at 2:25 PM Minsuk Ji notifications@github.com wrote:

Yeah, I can confirm that it was /apps/lmod/init :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/70#issuecomment-649744499, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7D6TJN6RX52DKARXNCDFLRYOJAXANCNFSM4OIS5KBA .