search

NOAA-EMC / NEMS

NEMS (NOAA Environmental Modeling System)
https://noaa-emc.github.io/NEMS_doc/index.html
Other
11 stars 46 forks source link

bulk_methods #73

Closed hyunchul386 closed 3 years ago

hyunchul386 commented 3 years ago

to using U10m/V10m and T2m/Q2m of DATM_inputs for calculation of bulk formula fluxes in mediator

main changes

NEMS/src/module_MEDIATOR.F90 NEMS/src/module_MEDIATOR_methods.F90

hyunchul386 commented 3 years ago

I am updating module_MEDIATOR.F90 for bulk_method with the compilation option of "DATM".

On Mon, Jul 27, 2020 at 9:29 AM Jessica Meixner notifications@github.com wrote:

@JessicaMeixner-NOAA requested changes on this pull request.

A few points where we should clean up code. Are we still making updates to the NEMS mediator or should these be going into CMEPS? I know S2S has moved to CMEPS, but if this is going into the NEMS mediator, should we test to confirm that S2S answers are not changed by these updates? I think @DeniseWorthen https://github.com/DeniseWorthen and others currently working on DATM are more qualified to review the content of the changes themselves though.

In src/module_MEDIATOR.F90 https://github.com/NOAA-EMC/NEMS/pull/73#discussion_r460887589:

 call fld_list_add(fldsFrAtm,"mean_zonal_moment_flx_atm"   , "cannot provide","conservefrac")
  • !call fld_list_add(fldsFrAtm,"mean_zonal_moment_flx_atm" , "will provide","conservefrac")

remove line

In src/module_MEDIATOR.F90 https://github.com/NOAA-EMC/NEMS/pull/73#discussion_r460887618:

@@ -561,7 +564,9 @@ subroutine SetServices(gcomp, rc)

 ! Fields from ATM

+! LHC 2020

remove line

In src/module_MEDIATOR.F90 https://github.com/NOAA-EMC/NEMS/pull/73#discussion_r460888014:

@@ -4892,6 +4899,14 @@ subroutine MedPhase_atm_ocn_flux(gcomp, rc) character(ESMF_MAXSTR) ,pointer :: fieldNameList(:) real(ESMF_KIND_R8), pointer :: zbot(:,:),ubot(:,:),vbot(:,:),thbot(:,:), & qbot(:,:),rbot(:,:),tbot(:,:), pbot(:,:) +! LHC 2020

Remove LHC 2020 (and all other places it appears).

In src/module_MEDIATOR.F90 https://github.com/NOAA-EMC/NEMS/pull/73#discussion_r460888153:

+

  • call FieldBundle_GetFldPtr(is_local%wrap%FBAtm_o, 'inst_temp_height2m', t2m, rc=rc)
  • if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, &
  • line=LINE, file=FILE)) return ! bail out
  • call FieldBundle_GetFldPtr(is_local%wrap%FBAtm2_o, 'inst_temp_height2m', t2m2, rc=rc)
  • if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, &
  • line=LINE, file=FILE)) return ! bail out
  • call FieldBundle_GetFldPtr(is_local%wrap%FBAtm_o, 'inst_spec_humid_height2m', q2m, rc=rc)
  • if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, &
  • line=LINE, file=FILE)) return ! bail out
  • call FieldBundle_GetFldPtr(is_local%wrap%FBAtm2_o, 'inst_spec_humid_height2m', q2m2, rc=rc)
  • if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, &
  • line=LINE, file=FILE)) return ! bail out
  • ! call FieldBundle_GetFldPtr(is_local%wrap%FBAtm_o, 'mean_zonal_moment_flx_atm', mtaux, rc=rc)

remove block of commented out text

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/73#pullrequestreview-455777620, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADQ73E5JBC326LSRCJ2XH4TR5V6J7ANCNFSM4PIX55VA .

hyunchul386 commented 3 years ago

module_MEDIATOR.F90 was update in the develop branch on hyunchul386/NEMS, with the compilation option of "DATM".

hyunchul386 commented 3 years ago

This update of bulk-option is aimed to reproduce in ufs-s2s and ufs-weather, which use " #ifdef FV3_CPLD ", and "the bulk methods" can be applied only if "DATM" is used.

On Mon, Jul 27, 2020 at 11:39 AM Denise Worthen notifications@github.com wrote:

@DeniseWorthen commented on this pull request.

In src/module_MEDIATOR.F90 https://github.com/NOAA-EMC/NEMS/pull/73#discussion_r460983310:

@@ -4890,8 +4895,17 @@ subroutine MedPhase_atm_ocn_flux(gcomp, rc) type(InternalState) :: is_local integer :: i,j,n character(ESMF_MAXSTR) ,pointer :: fieldNameList(:) + +! LHC 2020 +#ifndef DATM

The existing option for using the aofluxes is #ifdef FV3_CPLD; but beyond that, you should have a way of controlling which formulation to use when the aofluxes are actually being calculated.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/73#pullrequestreview-455902053, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADQ73E7F7FTTYU3OYHPGH3TR5WNT3ANCNFSM4PIX55VA .

hyunchul386 commented 3 years ago

I agree with the controlling the aofluxes, and will updated it accordingly. Thanks.

On Mon, Jul 27, 2020 at 11:47 AM Hyun-Chul Lee - NOAA Affiliate < hyun-chul.lee@noaa.gov> wrote:

This update of bulk-option is aimed to reproduce in ufs-s2s and ufs-weather, which use " #ifdef FV3_CPLD ", and "the bulk methods" can be applied only if "DATM" is used.

On Mon, Jul 27, 2020 at 11:39 AM Denise Worthen notifications@github.com wrote:

@DeniseWorthen commented on this pull request.

In src/module_MEDIATOR.F90 https://github.com/NOAA-EMC/NEMS/pull/73#discussion_r460983310:

@@ -4890,8 +4895,17 @@ subroutine MedPhase_atm_ocn_flux(gcomp, rc) type(InternalState) :: is_local integer :: i,j,n character(ESMF_MAXSTR) ,pointer :: fieldNameList(:) + +! LHC 2020 +#ifndef DATM

The existing option for using the aofluxes is #ifdef FV3_CPLD; but beyond that, you should have a way of controlling which formulation to use when the aofluxes are actually being calculated.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/73#pullrequestreview-455902053, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADQ73E7F7FTTYU3OYHPGH3TR5WNT3ANCNFSM4PIX55VA .

hyunchul386 commented 3 years ago

The module_MEDIATOR.F90 was updated for controlling "aofluxes calc with DATM" in the develop branch on hyunchul386/NEMS, and let me know any comments. -- Thanks a lot

hyunchul386 commented 3 years ago

module_MEDIATOR.F90 was updated for the logical flag of "bulk_method_ori" which control the method of bulk formular in module_MEDIATOR.F90. The default is the original method.

MinsukJi-NOAA commented 3 years ago

@DeniseWorthen @binli2337 @junwang-noaa ,as we move from NEMS to CMEPS, would you please advise @hyunchul386 where he can port his code changes within the CMEPS framework?

junwang-noaa commented 3 years ago

here is EMC's CMEPS repo: https://github.com/NOAA-EMC/CMEPS

On Thu, Aug 27, 2020 at 9:15 AM Minsuk Ji notifications@github.com wrote:

@DeniseWorthen https://github.com/DeniseWorthen @binli2337 https://github.com/binli2337 @junwang-noaa https://github.com/junwang-noaa ,as we move from NEMS to CMEPS, would you please advise @hyunchul386 https://github.com/hyunchul386 where he can port his code changes within the CMEPS framework?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/73#issuecomment-681941598, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7D6TOAFZWVGSMTELNZ3FTSCZL6PANCNFSM4PIX55VA .

hyunchul386 commented 3 years ago

Thanks for letting me know. -- Hyun-Chul

On Thu, Aug 27, 2020 at 9:17 AM Jun Wang notifications@github.com wrote:

here is EMC's CMEPS repo: https://github.com/NOAA-EMC/CMEPS

On Thu, Aug 27, 2020 at 9:15 AM Minsuk Ji notifications@github.com wrote:

@DeniseWorthen https://github.com/DeniseWorthen @binli2337 https://github.com/binli2337 @junwang-noaa https://github.com/junwang-noaa ,as we move from NEMS to CMEPS, would you please advise @hyunchul386 https://github.com/hyunchul386 where he can port his code changes within the CMEPS framework?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/73#issuecomment-681941598, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AI7D6TOAFZWVGSMTELNZ3FTSCZL6PANCNFSM4PIX55VA

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/73#issuecomment-681943103, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADQ73E446PPDM5PNYXUMGTTSCZMIBANCNFSM4PIX55VA .

MinsukJi-NOAA commented 3 years ago

@hyunchul386, can I close this PR?

hyunchul386 commented 3 years ago

Yes, it can be closed.

On Fri, Nov 20, 2020 at 9:17 AM Minsuk Ji notifications@github.com wrote:

@hyunchul386 https://github.com/hyunchul386, can I close this PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/73#issuecomment-731195980, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADQ73E3KS7XFY6FN33HW4HLSQZ27FANCNFSM4PIX55VA .