search

NOAA-EMC / NEMS

NEMS (NOAA Environmental Modeling System)
https://noaa-emc.github.io/NEMS_doc/index.html
Other
11 stars 46 forks source link

Sm jul272020 #79

Open SMoorthi-emc opened 4 years ago

SMoorthi-emc commented 4 years ago

I have many changes in NEMS that should make it leaner and cleaner. I am putting this pull request as suggested by Arun for consideration.

DeniseWorthen commented 4 years ago

@MinsukJi-NOAA. I do not have time for this review. Could you please request Bin instead?

DeniseWorthen commented 4 years ago

@MinsukJi-NOAA @arunchawla-NOAA Thanks Minsuk

SMoorthi-emc commented 4 years ago

Please consider asking Shan Sun to review.

junwang-noaa commented 4 years ago

Moorthi,

There are many mediator.F90 files, please remote those temporary ones.

On Tue, Aug 25, 2020 at 9:04 AM SMoorthi-emc notifications@github.com wrote:

Please consider asking Shan Sun to review.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/79#issuecomment-680010777, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7D6TM74CUO7KBJHHXY7BDSCOY67ANCNFSM4QKQSLLA .

SMoorthi-emc commented 4 years ago

Yes, it wasn't working at some point. Moorthi

On Tue, Aug 25, 2020 at 9:21 AM Jun Wang notifications@github.com wrote:

@junwang-noaa commented on this pull request.

In src/incmake/configure_rules.mk https://github.com/NOAA-EMC/NEMS/pull/79#discussion_r476437723:

@@ -1,4 +1,4 @@

+NCP="/bin/cp"

Why do we need this? Is cp not working?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/79#pullrequestreview-474466894, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLVRYT6D32PZUVSO62YTXDSCO2IFANCNFSM4QKQSLLA .

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718

e-mail: Shrinivas.Moorthi@noaa.gov Phone: (301) 683-3718 Fax: (301) 683-3718

SMoorthi-emc commented 4 years ago

They have been removed Moorthi

On Tue, Aug 25, 2020 at 9:23 AM Jun Wang notifications@github.com wrote:

Moorthi,

There are many mediator.F90 files, please remote those temporary ones.

On Tue, Aug 25, 2020 at 9:04 AM SMoorthi-emc notifications@github.com wrote:

Please consider asking Shan Sun to review.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/79#issuecomment-680010777, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AI7D6TM74CUO7KBJHHXY7BDSCOY67ANCNFSM4QKQSLLA

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/79#issuecomment-680017731, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLVRYR7LXYEPBY5E3WWCL3SCO2OLANCNFSM4QKQSLLA .

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718

e-mail: Shrinivas.Moorthi@noaa.gov Phone: (301) 683-3718 Fax: (301) 683-3718

MinsukJi-NOAA commented 4 years ago

@SMoorthi-emc, if you have run the regression tests for the weather and s2s model, please let us know.That will help with the merging process.

SMoorthi-emc commented 4 years ago

No, I haven't.

On Fri, Aug 28, 2020 at 9:12 AM Minsuk Ji notifications@github.com wrote:

@SMoorthi-emc https://github.com/SMoorthi-emc, if you have run the regression tests for the weather and s2s model, please let us know.That will help with the merging process.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/79#issuecomment-682551707, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLVRYQK3UCEQUDHLHIDVYDSC6UNFANCNFSM4QKQSLLA .

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718

e-mail: Shrinivas.Moorthi@noaa.gov Phone: (301) 683-3718 Fax: (301) 683-3718

MinsukJi-NOAA commented 4 years ago

Do we need these compile_*.sh files under NEMS?

SMoorthi-emc commented 4 years ago

No. I had it before we had the current compile.sh. I will remove.

On Fri, Aug 28, 2020 at 9:33 AM Minsuk Ji notifications@github.com wrote:

Do we need these compile_*.sh files under NEMS?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/79#issuecomment-682577778, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLVRYVCAFULUT3THQAPTCDSC6W2DANCNFSM4QKQSLLA .

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718

e-mail: Shrinivas.Moorthi@noaa.gov Phone: (301) 683-3718 Fax: (301) 683-3718

MinsukJi-NOAA commented 4 years ago

No, I haven't.

Given the amount of clean up/code changes, we should probably run the regression tests for both weather and s2s.

SMoorthi-emc commented 4 years ago

I guess there are no regressions tests with NEMS mediator anymore right? The NEMS mediator does change results because it now works for both fractional and non-fractional grids. However, there are no changes affecting CMEPS, except that the coupled executable compiled with CMEPS can now be used to run standalone FV3.

On Fri, Aug 28, 2020 at 9:38 AM Minsuk Ji notifications@github.com wrote:

No, I haven't.

Given the amount of clean up/code changes, we should probably run the regression tests for both weather and s2s.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/79#issuecomment-682580327, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLVRYXBUI7QC34ALWHBOP3SC6XN3ANCNFSM4QKQSLLA .

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718

e-mail: Shrinivas.Moorthi@noaa.gov Phone: (301) 683-3718 Fax: (301) 683-3718

MinsukJi-NOAA commented 3 years ago

@SMoorthi-emc, can we close this PR?

SMoorthi-emc commented 3 years ago

Why?

MinsukJi-NOAA commented 3 years ago

Moorthi, it wasn't clear to me since it has been some time and we have moved from NEMS to CMEPS. Please let me know if I am mistaken, and/or what your plans are regarding this PR