search

NOAA-EMC / NEMS

NEMS (NOAA Environmental Modeling System)
https://noaa-emc.github.io/NEMS_doc/index.html
Other
11 stars 46 forks source link

set total forecast time to be real #81

Closed junwang-noaa closed 3 years ago

junwang-noaa commented 3 years ago

Set total forecast time to be real number to allow flexible forecast time

Related PRs:

fv3 PR #175 NEMS PR #81 ufs-weather-model PR #206

climbfuji commented 3 years ago

Thanks! This change has been overdue.

junwang-noaa commented 3 years ago

Dom, thanks for reviewing it. We need to test this branch for LAM and HAFS to confirm it works for high resolution runs before we run RT and commit the code.

On Tue, Sep 22, 2020 at 3:31 PM Dom Heinzeller notifications@github.com wrote:

@climbfuji approved this pull request.

I haven't tested it, but it looks ok to me.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/81#pullrequestreview-493781863, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7D6TOTBQXLGB2463LTW6DSHD3QZANCNFSM4RVGEJDQ .

MinsukJi-NOAA commented 3 years ago

@junwang-noaa, Is this PR ready for merge?

junwang-noaa commented 3 years ago

Minsuk,

I am running RT, it is supposed to be committed with ufs-weather-model PR

206.

On Mon, Nov 2, 2020 at 11:01 AM Minsuk Ji notifications@github.com wrote:

@junwang-noaa https://github.com/junwang-noaa, Is this PR ready for merge?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/81#issuecomment-720562400, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7D6TN2VKPKRZZVECKNCHLSN3JVFANCNFSM4RVGEJDQ .

junwang-noaa commented 3 years ago

Minsuk, All the RTs are done. You can merge the PR. Thanks

On Mon, Nov 2, 2020 at 11:21 AM Jun Wang - NOAA Federal jun.wang@noaa.gov wrote:

Minsuk,

I am running RT, it is supposed to be committed with ufs-weather-model PR

206.

On Mon, Nov 2, 2020 at 11:01 AM Minsuk Ji notifications@github.com wrote:

@junwang-noaa https://github.com/junwang-noaa, Is this PR ready for merge?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/81#issuecomment-720562400, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7D6TN2VKPKRZZVECKNCHLSN3JVFANCNFSM4RVGEJDQ .