search

NOAA-EMC / NEMS

NEMS (NOAA Environmental Modeling System)
https://noaa-emc.github.io/NEMS_doc/index.html
Other
11 stars 46 forks source link

update required after UFS-weather PR #213 #82

Closed aerorahul closed 3 years ago

aerorahul commented 3 years ago

CCPP fails to build with gnu make in UFS-s2s-model following UFS-weather PR https://github.com/ufs-community/ufs-weather-model/pull/213 This fixes that issue.

aerorahul commented 3 years ago

The code changes look good. We will also need a ufs-weather PR and a ufs-s2s PR.

There is a s2s pr already. I can include it in my weather pr, although it does not break the weather model since it does not use gnumake.

junwang-noaa commented 3 years ago

Yea, we just need to keep ufs-weather and ufs-s2s synced with the same subcomponent. I don't think we need ufs-weather RT so it can be committed at the same time with ufs-s2s PR.

On Sat, Oct 10, 2020 at 11:37 AM Rahul Mahajan notifications@github.com wrote:

The code changes look good. We will also need a ufs-weather PR and a ufs-s2s PR.

There is a s2s pr already. I can include it in my weather pr, although it does not break the weather model since it does not use gnumake.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NEMS/pull/82#issuecomment-706567385, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7D6TLC74Q7AUZMDSAJJTLSKB5RPANCNFSM4SLDKARA .

aerorahul commented 3 years ago

Yea, we just need to keep ufs-weather and ufs-s2s synced with the same subcomponent. I don't think we need ufs-weather RT so it can be committed at the same time with ufs-s2s PR. … On Sat, Oct 10, 2020 at 11:37 AM Rahul Mahajan @.***> wrote: The code changes look good. We will also need a ufs-weather PR and a ufs-s2s PR. There is a s2s pr already. I can include it in my weather pr, although it does not break the weather model since it does not use gnumake. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#82 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7D6TLC74Q7AUZMDSAJJTLSKB5RPANCNFSM4SLDKARA .

Ok. After this NEMS PR is merged, I/someone can open a weather PR to update the NEMS submodule pointer.