search

NOAA-EMC / RDASApp

Regional DAS
GNU Lesser General Public License v2.1
1 stars 13 forks source link

Discussion on the RDASApp code management policy #143

Open guoqing-noaa opened 2 months ago

guoqing-noaa commented 2 months ago

Start a thread to discuss some RDASApp code management policy. Inputs are very welcome from all developers.

As a starting point, I made a simple preliminary draft on the wiki page: https://github.com/NOAA-EMC/RDASApp/wiki/RDASApp-code-management-policy

TingLei-NOAA commented 1 month ago

I would suggest one important guideline: 

Generally, the developer submitting the PR and the one merging it to the repo should not be the person
guoqing-noaa commented 1 month ago

@TingLei-NOAA Thanks for the contribution. I would take this as a suggestion that we need more rigorous PR review before a merge (it is the review process that matters not who merges a PR). I share the same concern.

I would advocate each PR should have at least two approvals, and it is preferred that one from GSL and one from EMC. And if any reviewer thinks a change is required before a merge, he/she can use the "request changes" button (shown as below) to block a PR until changes have been made and should communicate clearly what changes are proposed.

image