search

NOAA-EMC / RDASApp

Regional DAS
GNU Lesser General Public License v2.1
1 stars 11 forks source link

Update OOPS and IODA hashes #189

Open SamuelDegelia-NOAA opened 2 weeks ago

SamuelDegelia-NOAA commented 2 weeks ago

As discussed in #122, the reduce obs space filter action can significantly reduce the runtime and memory cost of GETKF. But there is currently a bug in OOPS related to the order that the linear and nonlinear h(x) quantities are initialized. This bug leads to a crash when using reduce obs space for GETKF. A PR was just merged to fix this bug. As such, we will need to update the OOPS hash to make use of this filter action. Additionally, I tested the branch in the OOPS PR and found that we will also need to update the IODA hash at the same time.

hu5970 commented 2 weeks ago

@SamuelDegelia-NOAA Thanks for bring this issue up. Hongli and Junjun are working on sync latest JEDI-bundle repositories to RDASApp.

SamuelDegelia-NOAA commented 2 weeks ago

Thanks @hu5970, glad to hear that this is being worked on.

guoqing-noaa commented 2 weeks ago

link to issue #154

guoqing-noaa commented 1 week ago

@SamuelDegelia-NOAA The PR you mentioned is too new and mpasjedi.v3.0.1 did not include that commit. The latest commit of OOPS is at:

commit d77217323bbbd02ea41049fe1bd339f24a64f177 (HEAD)
Author: Tom Hill <109206633+tom-j-h@users.noreply.github.com>
Date:   Fri Aug 30 00:01:50 2024 +0100

The latest commit of IODA is at:

commit d49ed17e115f5d7ff3310cd1dfe4798c10aa03db (HEAD)
Author: Francois Hebert <hebert@ucar.edu>
Date:   Mon Sep 9 17:06:03 2024 -0600

    Fix missing include (#1333)

I think the best way forward is that we merge PR #193 first and then you can continue working on this issue. Is that okay for you? Thanks!

SamuelDegelia-NOAA commented 1 week ago

That's no problem! We can update it at a later date - no rush.