search

NOAA-EMC / RDASApp

Regional DAS
GNU Lesser General Public License v2.1
0 stars 5 forks source link

Add cron to update stable branch #20

Closed CoryMartin-NOAA closed 1 month ago

CoryMartin-NOAA commented 1 month ago

Using submodules means that develop has to be manually updated. But we can create a cron that will ensure that feature/stable-nightly has the most recent versions of JEDI repositories that build and tests pass.

To do this, the default branches had to be updated/added for the repositories. This is because the public JCSDA repos have master branches as default but we usually need develop. Running git submodule update on the public repos would have resulted in grabbing very old commits rather than recent ones.

Note: this script will not run properly until develop is updated with those submodule changes in .gitmodules. To test, one can add git checkout feature/update-stable in the stable_driver.sh script right after git checkout develop but this was tested manually yesterday on Orion. See: https://github.com/NOAA-EMC/RDASApp/tree/feature/stable-nightly

TingLei-NOAA commented 1 month ago

@CoryMartin-NOAA Thanks for taking care of this, which we think is the reason why some ctests failed with the current rdas. After the changes in the .gitmodules and run your script to change branches to right branches. In the future , unless there are specific requirements for versions of various submodules, we could run "git submodule update --remote --merge" rather than "git submodule update" to make sure all submodules are updated to their latest develop/targeted branches.

CoryMartin-NOAA commented 1 month ago

@CoryMartin-NOAA Thanks for taking care of this, which we think is the reason why some ctests failed with the current rdas. After the changes in the .gitmodules and run your script to change branches to right branches. In the future , unless there are specific requirements for versions of various submodules, we could run "git submodule update --remote --merge" rather than "git submodule update" to make sure all submodules are updated to their latest develop/targeted branches.

@TingLei-NOAA yes, in fact this script: https://github.com/NOAA-EMC/RDASApp/blob/develop/ush/submodules/update_develop.sh does exactly that, it wasn't working correctly but it does now.

emcbot commented 1 month ago

Automated RDASApp Testing Results: Machine: hera

Start: Wed Apr  3 13:36:50 UTC 2024 on hfe09
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Apr  3 14:20:37 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Apr  3 14:21:00 UTC 2024
Tests:
emcbot commented 1 month ago

Automated RDASApp Testing Results: Machine: orion

Start: Wed Apr  3 08:47:14 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Apr  3 09:33:10 CDT 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Apr  3 09:33:32 CDT 2024
Tests: