search

NOAA-EMC / RDASApp

Regional DAS
GNU Lesser General Public License v2.1
0 stars 5 forks source link

A rrfs Ens3Dvar test for mpasjedi is added #23

Closed TingLei-NOAA closed 1 month ago

TingLei-NOAA commented 1 month ago

Following the similar procedure by which a rrfs test for fv3jedi was added, a rrfs Ens3Dvar test is added for mpasjedi. The ctest name is rrfs_mpasjedi_2022052619_Ens3Dvar. Also, now the env variable pointing to the location of the local dir containing the rrfs data is set in the machine specific module file.

CoryMartin-NOAA commented 1 month ago

@TingLei-NOAA I noticed you force pushed, If you do that it makes reviews harder because I can't view "changes since your last review". I know that was the old GSI way of doing things, but now we don't have to force push, we can just push each commit and squash them when merging in to develop.

TingLei-NOAA commented 1 month ago

@CoryMartin-NOAA Thanks for this reminder. I will avoid using "push --force" unless I am more strongly confident that some trivial changes are not interesting to the reviewers.