NOAA-EMC / RDASApp

Regional DAS
GNU Lesser General Public License v2.1
1 stars 13 forks source link

[bug] Sounding observation counts discrepancy between JEDI and GSI #233

Open delippi opened 8 hours ago

delippi commented 8 hours ago

Current behavior (describe the bug)

When processing ADPUPA (120/220) sounding data in JEDI, the observation counts appear significantly lower compared to GSI. Specifically, in the RRFS FV3-JEDI ctest case (2022-05-26T19:00:00Z):

With all QC filters turned off, the JEDI log has the following information:

 0: QC apdupa_airTemperature_120 airTemperature: 247 missing values.
 0: QC apdupa_airTemperature_120 airTemperature: 96 passed out of 343 observations.

We are not sure if this is a problem during the bufr2ioda conversion, in the JEDI configuration, or in JEDI itself.

Steps to Reproduce (if applicable)

What computer are you running on?

Hera

Steps to reproduce the behavior

  1. Copy phase 2 workspace: /scratch2/NCEPDEV/fv3-cam/Donald.E.Lippi/RRFSv2/jedi-assim-phase2. The only parts needed are as follows

    • run_all.sh
    • rrfs-data_fv3jedi_2022052619/
    • gsi_2022052619/
  2. Run run_all.sh

    • RUN_GSI, RUN_JEDI, MAKE_PLOT, use_offline_domain_check should all be "YES". After running GSI the first time set RUN_GSI="NO".
    • change paths for jedi_dir, gsi_dir to where ever you copied the rrfs and gsi case directories from step 1.
    • obtype_configs="$obtype_configs adpupa_airTemperature_120.yaml" should be the only uncommented obstype_config
    • Other paths should be okay.
    • gsi_2022052619/run_gsi.sh will use my GSI build (unless changed)
    • rrfs-data_fv3jedi_2022052619/run_fv3jedi.sh will use my JEDI build (unless changed)
    • bash ./run_all.sh
    • check the ./rrfs-data_fv3jedi_2022052619/conv.yaml (template yamls are in the valid_yamls path in ./run_all.sh)

Expected behavior

Observation counts between JEDI and GSI should be more similar.

Suggested Solution (if known)

Unknown at this point.

Acceptance Criteria (Definition of Done)

Dependencies

RDASApp Issue https://github.com/NOAA-EMC/RDASApp/issues/232 HDASApp Issue https://github.com/NOAA-EMC/HDASApp/issues/16

Additional information (optional)

IODA re-processing data is done: /scratch2/NCEPDEV/fv3-cam/Donald.E.Lippi/RRFSv2/ioda_processing Relevant files include:

# The full obs file:
./ioda/ioda_adpupa.nc

# The offline domain check (dc) file:
./ioda/ioda_adpupa_dc.png
./ioda/ioda_adpupa_dc.nc

# yaml used for converter
./yaml/prepbufr_adpupa.yaml