search

NOAA-EMC / RTOFS_GLO

0 stars 1 forks source link

Improve err check for some RTOFS ush scripts (bugzilla #1141) #20

Open DanIredell-NOAA opened 2 years ago

DanIredell-NOAA commented 2 years ago

http://www2.spa.ncep.noaa.gov/bugzilla/show_bug.cgi?id=1141

Please improve err check for RTOFS ush scripts at next upgrade.

Bugzilla ticket is submitted for the following 4 ush scripts that don't have err handling. and the scripts calling them do not have an err check right after. rtofs_atmforcing_extract.sh rtofs_surface_day1-3.sh rtofs_surface_day4-5.sh rtofs_surface_hcasts.sh

DanIredell-NOAA commented 11 months ago

INFO: ush/rtofs_atmforcing_stage.sh calls ush/rtofs_atmforcing_extract.sh. scripts/exrtofs_glo_grib2_post.sh calls the other 3 ush scripts (called ops_script)

Generally err_chk is not called when an ush script fails... mainly on EXECs.

rtofs_atmforcing_extract.sh calls WGRIB [see note]. I suppose that the return code can be checked on WGRIB. *WGRIB is only called when 'useslp' is YES. Generally it is not set that way.

The opc scripts (ush/rtofssurface*.sh) call cdo. ush/rtofs_nc2grib2.sh does as well. Neither of these scripts check for the return code from cdo.

Upshot - can add 'err=$?; export err; err_chk' to WGRIB and CDO, but that seems unnecessary.

DanIredell-NOAA commented 7 months ago

Added _err=$?; export err ; errchk after calls to cdo and wgrib2