search

NOAA-EMC / TC_tracker

4 stars 6 forks source link

Update/generalize paths for GFSv17 COM reorg #2

Closed WalterKolczynski-NOAA closed 11 months ago

WalterKolczynski-NOAA commented 1 year ago

The upcoming update to GFS v17 will substantially change the COM paths for the GFS package. When called within global workflow, $COMINgfs now contains the full path to the desired directories. This requires changes to how the look-behind and look-ahead are done. Now instead of constructing the path itself, the lookbehind and look-ahead now do a substitution of ${PDY}/${cyc} with the new desired values for the other cycles.

Additional changes will be needed to the j-jobs to match the updated $COMINgfs pattern for GFS v17 in order to run this as a seperate system (as in ops). Also, not all GFS tracker jobs are currently available in the global workflow, so changes for FSU genesis have not been tested.

Additional changes will also be needed for GEFS v13, which is making similar changes to COM.

Refs: #1 Refs: NOAA-EMC/global-workflow#761

JiayiPeng-NOAA commented 1 year ago

Hi Walter, With the COMINgfs/COMINgefs changes, the TC track/genesis package will be updated. I will test and make a new TAG for this update. Thanks, Jiayi

On Mon, Apr 10, 2023 at 3:48 PM Walter Kolczynski - NOAA < @.***> wrote:

The upcoming update to GFS v17 will substantially change the COM paths for the GFS package. When called within global workflow, $COMINgfs now contains the full path to the desired directories. This requires changes to how the look-behind and look-ahead are done. Now instead of constructing the path itself, the lookbehind and look-ahead now do a substitution of ${PDY}/${cyc} with the new desired values for the other cycles.

Additional changes will be needed to the j-jobs to match the updated $COMINgfs pattern for GFS v17 in order to run this as a seperate system (as in ops). Also, not all GFS tracker jobs are currently available in the global workflow, so changes for FSU genesis have not been tested.

Additional changes will also be needed for GEFS v13, which is making similar changes to COM.

Refs: #1 https://github.com/NOAA-EMC/TC_tracker/issues/1 Refs: NOAA-EMC/global-workflow#761 https://github.com/NOAA-EMC/global-workflow/issues/761

You can view, comment on, or merge this pull request online at:

https://github.com/NOAA-EMC/TC_tracker/pull/2 Commit Summary

File Changes

(4 files https://github.com/NOAA-EMC/TC_tracker/pull/2/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/TC_tracker/pull/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALRTVNKMEE3XU277CFMHT3DXARPXBANCNFSM6AAAAAAWZK6R5A . You are receiving this because your review was requested.Message ID: @.***>

KateFriedman-NOAA commented 1 year ago

Hi Walter, With the COMINgfs/COMINgefs changes, the TC track/genesis package will be updated. I will test and make a new TAG for this update. Thanks, Jiayi

@JiayiPeng-NOAA Please cut a new tag with the Jet updates before ingesting the COM reorg updates. Thanks!

JiayiPeng-NOAA commented 1 year ago

Hi Kate, I Agree. I will make this version/TAG working for Wcoss2/Jet/Hera/Orion, and another TAG to adopt COMINgfs/COMINgefs changes. Thanks, Jiayi

On Tue, Apr 11, 2023 at 1:32 PM Kate Friedman @.***> wrote:

Hi Walter, With the COMINgfs/COMINgefs changes, the TC track/genesis package will be updated. I will test and make a new TAG for this update. Thanks, Jiayi

@JiayiPeng-NOAA https://github.com/JiayiPeng-NOAA Please cut a new tag with the Jet updates before ingesting the COM reorg updates. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/TC_tracker/pull/2#issuecomment-1503818742, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALRTVNOSFD376MSYAAHY4Q3XAWIRNANCNFSM6AAAAAAWZK6R5A . You are receiving this because you were mentioned.Message ID: @.***>

KateFriedman-NOAA commented 1 year ago

I will make this version/TAG working for Wcoss2/Jet/Hera/Orion, and another TAG to adopt COMINgfs/COMINgefs changes.

Perfect, thanks @JiayiPeng-NOAA !

WalterKolczynski-NOAA commented 11 months ago

@JiayiPeng-NOAA What happened with this PR?

JiayiPeng-NOAA commented 11 months ago

Hi Walter, Please go ahead to close this PR. Thanks, Jiayi

On Mon, Oct 23, 2023 at 6:17 AM Walter Kolczynski - NOAA < @.***> wrote:

@JiayiPeng-NOAA https://github.com/JiayiPeng-NOAA What happened with this PR?

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/TC_tracker/pull/2#issuecomment-1774871393, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALRTVNPTAOKOPWHKMRJJQOTYAY74NAVCNFSM6AAAAAAWZK6R5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUHA3TCMZZGM . You are receiving this because you were mentioned.Message ID: @.***>

WalterKolczynski-NOAA commented 11 months ago

@JiayiPeng-NOAA Okay, should I open a new one for the current develop? We do need to get these updates in.

JiayiPeng-NOAA commented 11 months ago

Hi Walter, What updates do you have? Structure changes? and /or module/library changes? Thanks, Jiayi

On Mon, Oct 23, 2023 at 1:21 PM Walter Kolczynski - NOAA < @.***> wrote:

@JiayiPeng-NOAA https://github.com/JiayiPeng-NOAA Okay, should I open a new one for the current develop? We do need to get these updates in.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/TC_tracker/pull/2#issuecomment-1775661936, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALRTVNPJEUR2SZ6WL42IYSLYA2RPZAVCNFSM6AAAAAAWZK6R5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZVGY3DCOJTGY . You are receiving this because you were mentioned.Message ID: @.***>

WalterKolczynski-NOAA commented 11 months ago

The updates that were in this PR. Just path changes, but they require a different approach.