search

NOAA-EMC / UPP

Other
38 stars 100 forks source link

thousands of warnings from UPP code from gfortran #1065

Open edwardhartnett opened 1 month ago

edwardhartnett commented 1 month ago

When I run UPP through gfortran I get thousands of warnings.

I presented these results in a slideshow to the UPP team some time ago, and there was not much interest. But I am opening an issue to record this.

Build with gfortran -Wall and you will find many defects in UPP code that should be cleaned up. I suggest you clear all warnings and then set up the CI system to prevent careless programmers from introducing more.

Here's the slide about warnings in your code from a presentation about UFS code quality and issues. As the slide says, don't try and fix your warnings without unit testing first, or you will just break more stuff.

image

gspetro-NOAA commented 1 month ago

Thanks, Ed! Our software integration team is planning to write up a UPP unit testing plan this PI, and I think they will be in touch with you if they haven't been already. I suspect implementation will take quite a while, but it's at least on EPIC's radar. Thanks for creating the issue. :)

edwardhartnett commented 1 month ago

Prototype unit test implementation, with first few tests, can be found here: https://github.com/edwardhartnett/UPP/pull/1

Glad to hear this code is getting some testing! Let me know if you need help.