NOAA-EMC / UPP

Other
36 stars 98 forks source link

Update UPP for rocky8 transition on Hera and Jet #895

Closed WenMeng-NOAA closed 6 months ago

WenMeng-NOAA commented 6 months ago

Update UPP for rocky8 transition on Hera and Jet.

FernandoAndrade-NOAA commented 6 months ago

Hi @WenMeng-NOAA, I had no changed results after making similar changes and running RTs/compile for Hera and Jet on Thursday/Friday. Would you like me to rerun for this PR when it's ready or would that pretesting be sufficient?

WenMeng-NOAA commented 6 months ago

Hi @WenMeng-NOAA, I had no changed results after making similar changes and running RTs/compile for Hera and Jet on Thursday/Friday. Would you like me to rerun for this PR when it's ready or would that pretesting be sufficient?

@FernandoAndrade-NOAA Your pre-testing on Hera should be sufficient. Please let me know if you have more comments.

WenMeng-NOAA commented 6 months ago

@FernandoAndrade-NOAA The building (compiling) test on Jet was successful.

FernandoAndrade-NOAA commented 6 months ago

Hi @WenMeng-NOAA, I had no changed results after making similar changes and running RTs/compile for Hera and Jet on Thursday/Friday. Would you like me to rerun for this PR when it's ready or would that pretesting be sufficient?

@FernandoAndrade-NOAA Your pre-testing on Hera should be sufficient. Please let me know if you have more comments.

Sounds good, thanks! I'll go ahead and start up RTs on Orion and Hercules

WenMeng-NOAA commented 6 months ago

The UPP RTs were completed on WCOSS2 without changed results.

WenMeng-NOAA commented 6 months ago

Will a lot of developers/users still be working on CentOS between now and April 2nd on Hera? Would it make more sense to transition entirely to Rocky 8 so an additional PR is not required after the upgrade?

I'm not sure when Jet and kjet will be upgraded, but it should not be much longer after that, so the same question applies there.

@DavidHuber-NOAA The modulefiles jet_c.lua and hera_c.lua are for CentOS 7 nodes on Jet and Hera.

DavidHuber-NOAA commented 6 months ago

@WenMeng-NOAA Yes, I see that, but my question is if those really need to be included. Since CentOS will only be available for another two weeks, does the UPP really need to support CentOS during that period?

If the answer is yes, then I should point out that in two weeks, the build script will attempt to compile using hera_c modules when logged into nodes hfe01 through hfe08, which will fail. Thus, a new UPP PR will need to be written soon and all downstream applications will need to pick it up.

WenMeng-NOAA commented 6 months ago

@WenMeng-NOAA Yes, I see that, but my question is if those really need to be included. Since CentOS will only be available for another two weeks, does the UPP really need to support CentOS during that period?

If the answer is yes, then I should point out that in two weeks, the build script will attempt to compile using hera_c modules when logged into nodes hfe01 through hfe08, which will fail. Thus, a new UPP PR will need to be written soon and all downstream applications will need to pick it up.

@DavidHuber-NOAA The hera_c and jet_c are workaround for our UPP developers from GFS and RRFS during rocky8 transition period. GSL has been running RRFS parallel on Jet. When rocky8 transition on Hera is completed, I will update UPP for all rocky8 configuration.

DavidHuber-NOAA commented 6 months ago

Alright, that sounds good then.

WenMeng-NOAA commented 6 months ago

@DavidHuber-NOAA I will update upp revision at ufs-weather-model after rocky8 transition is done on Hera.

WenMeng-NOAA commented 6 months ago

This PR is ready for merging.