NOAA-EMC / UPP

Other
36 stars 98 forks source link

Add accumulated snow melt and surface albedo output in RRFS #904

Closed EricJames-NOAA closed 6 months ago

EricJames-NOAA commented 6 months ago

Accumulated snow melt (SNOM) and surface albedo are needed in RRFS. Also, we need to encode the total soil moisture as CISOILM.

WenMeng-NOAA commented 6 months ago

@EricJames-NOAA The UPP currently reads total soil moisture "soilm" from UFS based model output and writes it out as grib2 with name "SOILMOI". Could you clarify your intention of changing grib2 name from "SOILMOI" to "CISOILM"?

EricJames-NOAA commented 6 months ago

@WenMeng-NOAA yes, the previous code was an error. The soilm variable from UFS is in kg/m2, so it should be encoded as CISOILM (also in kg/m2). This code change is a bug fix.

WenMeng-NOAA commented 6 months ago

@WenMeng-NOAA yes, the previous code was an error. The soilm variable from UFS is in kg/m2, so it should be encoded as CISOILM (also in kg/m2). This code change is a bug fix.

@EricJames-NOAA I see. Thanks for catching that bug. I will change GFS products later.