search

NOAA-EMC / UPP

Other
33 stars 95 forks source link

Add surface albedo, accumulated snow melt, and total soil moisture output in RRFS #908

Closed EricJames-NOAA closed 3 months ago

EricJames-NOAA commented 3 months ago

This PR enables calculation and output of surface albedo, accumulated snow melt, and total soil moisture from RRFS.

The code was tested for RRFS-A (3km North America domain) on Jet. The only differences in output were for these variables.

WenMeng-NOAA commented 3 months ago

@EricJames-NOAA Can you provide me the RRFS model files for my UPP standalone test?

EricJames-NOAA commented 3 months ago

@EricJames-NOAA Can you provide me the RRFS model files for my UPP standalone test?

@WenMeng-NOAA I have some files here on Hera:

/scratch1/BMC/wrfruc/ejames/wen_snom_cisoilm/

WenMeng-NOAA commented 3 months ago

@EricJames-NOAA Please sync your branch with the latest UPP develop branch.

WenMeng-NOAA commented 3 months ago

@EricJames-NOAA My UPP standalone test with RRFS model files from you is located at /home/Wen.Meng/stmp2/rrfs_2024022718 on Hera. I saw total soil moisture, surface albedo and snow melt generated:

1414:8988243285:d=2024022718:CISOILM:0 m underground:6 hour fcst:
1628:10545816268:d=2024022718:ALBDO:surface:6 hour fcst
1446:9165494022:d=2024022718:SNOM:surface:5-6 hour acc fcst

Please verify and let me know if you find any inconsistency compared to your test.

EricJames-NOAA commented 3 months ago

@EricJames-NOAA My UPP standalone test with RRFS model files from you is located at /home/Wen.Meng/stmp2/rrfs_2024022718 on Hera. I saw total soil moisture, surface albedo and snow melt generated:

1414:8988243285:d=2024022718:CISOILM:0 m underground:6 hour fcst:
1628:10545816268:d=2024022718:ALBDO:surface:6 hour fcst
1446:9165494022:d=2024022718:SNOM:surface:5-6 hour acc fcst

Please verify and let me know if you find any inconsistency compared to your test.

@WenMeng-NOAA your results look consistent with my tests! Thanks!

WenMeng-NOAA commented 3 months ago

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There will be baseline updates for fv3r and 3drtma with this PR. You can refer to my tests on Hera at /home/Wen.Meng/stmp2:

Wen.Meng@hfe06 stmp2$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp    75 Apr  1 19:29 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp  2022 Apr  1 19:31 fv3r_2023062800/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2022 Apr  1 19:31 fv3r_2023062800_pe_test/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14823 Apr  1 19:32 rtma_2023040400_pe_test/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14823 Apr  1 19:32 rtma_2023040400/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14667 Apr  1 19:33 fv3r_2023062800/NATLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2589 Apr  1 19:34 rtma_2023040400_pe_test/PRSLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14667 Apr  1 19:34 fv3r_2023062800_pe_test/NATLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2589 Apr  1 19:34 rtma_2023040400/PRSLEV00.tm00.diff
FernandoAndrade-NOAA commented 3 months ago

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There will be baseline updates for fv3r and 3drtma with this PR. You can refer to my tests on Hera at /home/Wen.Meng/stmp2:

Wen.Meng@hfe06 stmp2$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp    75 Apr  1 19:29 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp  2022 Apr  1 19:31 fv3r_2023062800/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2022 Apr  1 19:31 fv3r_2023062800_pe_test/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14823 Apr  1 19:32 rtma_2023040400_pe_test/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14823 Apr  1 19:32 rtma_2023040400/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14667 Apr  1 19:33 fv3r_2023062800/NATLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2589 Apr  1 19:34 rtma_2023040400_pe_test/PRSLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14667 Apr  1 19:34 fv3r_2023062800_pe_test/NATLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2589 Apr  1 19:34 rtma_2023040400/PRSLEV00.tm00.diff

Hera, Hercules, and Orion RT results match with yours, looks good from my side, thanks.

WenMeng-NOAA commented 3 months ago

This PR is ready for merging.