Remove the detection of Jet/Centos7 nodes

NOAA-EMC / UPP

Other

36 stars 98 forks source link

Closed InnocentSouopgui-NOAA closed 6 months ago

InnocentSouopgui-NOAA commented 6 months ago

After the full migration of Jet to Centos8, it is no longer necessary to detect centos7 frontend; doing so results in the failure to build.
Remove the detection of Jet/Centos7 nodes and removes the associated module file jet_c.lua
This resolves issue #919
Refs NOAA-EMC/global-workflow#2377

WenMeng-NOAA commented 6 months ago

@FernandoAndrade-NOAA Can you test UPP building on jet with this PR?

FernandoAndrade-NOAA commented 6 months ago

FYI I've made an additional change to remove Hera's hfe12, it's a restricted node on centos following the recent maintenance.

FernandoAndrade-NOAA commented 6 months ago

@FernandoAndrade-NOAA Can you test UPP building on jet with this PR?

Building completed on Jet, I did not see any issues in the output. This was on fe4.

WenMeng-NOAA commented 6 months ago

@InnocentSouopgui-NOAA Can you sync your branch with the latest UPP develop branch for our merging process?

InnocentSouopgui-NOAA commented 6 months ago

@InnocentSouopgui-NOAA Can you sync your branch with the latest UPP develop branch for our merging process?

Done.

WenMeng-NOAA commented 6 months ago

@InnocentSouopgui-NOAA Thanks for contributing UPP updates for Jet Rocky8 transition.

WenMeng-NOAA commented 6 months ago

The UPP RTs were completed on WCOSS2. No baseline update is needed with this PR.

WenMeng-NOAA commented 6 months ago

@FernandoAndrade-NOAA Please let me know if you have more comments on this PR. I think testing on WCOSS2 should be adequate.

FernandoAndrade-NOAA commented 6 months ago

@FernandoAndrade-NOAA Please let me know if you have more comments on this PR. I think testing on WCOSS2 should be adequate.

I will go ahead and run a quick compile on Hera to ensure it's still detecting 10-11 correctly, that should be enough given nothing else was updated.

FernandoAndrade-NOAA commented 6 months ago

Looks good to go from my side, thank you.

WenMeng-NOAA commented 6 months ago

This PR is ready for merging.