search

NOAA-EMC / UPP

Other
33 stars 95 forks source link

For RRFS, change the mnemonics of column max of EDPARM to MXEDPRM #926

Closed YaliMao-NOAA closed 3 months ago

YaliMao-NOAA commented 3 months ago

To solve the issue #925, for RRFS, change the mnemonics of column max of EDPARM from EDPARM on 0m level to MXEDPRM of the entire atmosphere. For this purpose, MXEDPRM is added to both post_avblflds.xml and control file fv3lam_rrfs.xml

WenMeng-NOAA commented 3 months ago

@YaliMao-NOAA Can you sync your branch with the latest UPP develop?

WenMeng-NOAA commented 3 months ago

@YaliMao-NOAA My UPP-gtg standalone test results are at /u/wen.meng/ptmp/post_rrfs_2024032617 on Dogwwod. I can see your changes have been generated in IFIFIP dataset. Could you please verify my test?

WenMeng-NOAA commented 3 months ago

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There should be no baseline update with this PR.

YaliMao-NOAA commented 3 months ago

@YaliMao-NOAA My UPP-gtg standalone test results are at /u/wen.meng/ptmp/post_rrfs_2024032617 on Dogwwod. I can see your changes have been generated in IFIFIP dataset. Could you please verify my test?

@WenMeng-NOAA I can see the changes are correct in AVIATI09.tm00 as expected. But it should no have impact with IFIFIP. Did I miss anything?

WenMeng-NOAA commented 3 months ago

@YaliMao-NOAA My UPP-gtg standalone test results are at /u/wen.meng/ptmp/post_rrfs_2024032617 on Dogwwod. I can see your changes have been generated in IFIFIP dataset. Could you please verify my test?

@WenMeng-NOAA I can see the changes are correct in AVIATI09.tm00 as expected. But it should no have impact with IFIFIP. Did I miss anything?

@YaliMao-NOAA That's right. Your changes have no impact on IFI generation. Thanks for verifying.

WenMeng-NOAA commented 3 months ago

The UPP RTs were completed on WCOSS2 without baseline changes.

FernandoAndrade-NOAA commented 3 months ago

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There should be no baseline update with this PR.

RTs have completed successfully on Hera, Hercules, and Orion with no changes to results.

WenMeng-NOAA commented 3 months ago

This PR is ready for merging.