search

NOAA-EMC / UPP

Other
32 stars 95 forks source link

Clean up labeling for 15-min accumulated fields #948

Closed EricJames-NOAA closed 2 months ago

EricJames-NOAA commented 2 months ago

This PR includes the following changes:

(1) corrects the time labeling for the 15-min accumulated fields for RRFS (2) switch to use "BUCKET1" fields created for the HRRR 15-min output in RRFS (3) add sub-hourly control files to UPP repository (4) add output of 15-min graupel (which was included in HRRR)

There will be a final update needed to read the correct (actual 15-min acccumulation) fields in SURFCE.f.

The code was tested for RRFS_NA_3km on Jet.

WenMeng-NOAA commented 2 months ago

@EricJames-NOAA Do you have the sample model outputs for my testing on Hera?

WenMeng-NOAA commented 2 months ago

@EricJames-NOAA I would suggest updating the parm/makefile to add new RRFS sub-hourly control files.

EricJames-NOAA commented 2 months ago

@EricJames-NOAA Do you have the sample model outputs for my testing on Hera?

Yes, I have files here:

/scratch1/BMC/wrfruc/ejames/wen_subh/

WenMeng-NOAA commented 2 months ago

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. No baseline update is expected.

WenMeng-NOAA commented 2 months ago

The UPP RTs have been completed on WCOSS2.

FernandoAndrade-NOAA commented 2 months ago

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. No baseline update is expected.

RTs completed across machines with no changes to results. Looks good to go from my side. Despite the option for maintainers to be able to make changes to the PR, I had to manually copy and paste log info due to permission issues on pushing logs, @EricJames-NOAA please double check your repository in case any repo settings are overriding push permissions.

WenMeng-NOAA commented 2 months ago

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. No baseline update is expected.

RTs completed across machines with no changes to results. Looks good to go from my side. Despite the option for maintainers to be able to make changes to the PR, I had to manually copy and paste log info due to permission issues on pushing logs, @EricJames-NOAA please double check your repository in case any repo settings are overriding push permissions.

@FernandoAndrade-NOAA Do you have the instructions for updating the settings in developer's UPP fork so that RT logs can be automatically pushed?

WenMeng-NOAA commented 2 months ago

This PR is ready for merging.

FernandoAndrade-NOAA commented 2 months ago

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. No baseline update is expected.

RTs completed across machines with no changes to results. Looks good to go from my side. Despite the option for maintainers to be able to make changes to the PR, I had to manually copy and paste log info due to permission issues on pushing logs, @EricJames-NOAA please double check your repository in case any repo settings are overriding push permissions.

@FernandoAndrade-NOAA Do you have the instructions for updating the settings in developer's UPP fork so that RT logs can be automatically pushed?

I believe a quick fix for the push permissions to specific users would be to add Wen and myself as collaborators under your repo settings at the top > collaborators, that should allow us to push commits to your branches in the future.