search

NOAA-EMC / UPP

Other
36 stars 98 forks source link

Clean up compile warnings within the UPP code #964

Closed MatthewPyle-NOAA closed 3 months ago

MatthewPyle-NOAA commented 4 months ago

The UPP to be used for RRFS creates a few warning prints, seemingly in stub codes related to WRF I/O. 

/lfs/h2/emc/lam/noscrub/Matthew.Pyle/rrfs-workflow_warnings/sorc/UPP/sorc/ncep_post.fd/io_int_stubs.f(4): warning #6843: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value.   [STATUS]
SUBROUTINE ext_int_get_dom_ti_real ( DataHandle,Element,   Data, Count, Outcount, Status )
----------------------------------------------------------------------------------^
/lfs/h2/emc/lam/noscrub/Matthew.Pyle/rrfs-workflow_warnings/sorc/UPP/sorc/ncep_post.fd/io_int_stubs.f(4): warning #6843: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value.   [DATA]
SUBROUTINE ext_int_get_dom_ti_real ( DataHandle,Element,   Data, Count, Outcount, Status )
-----------------------------------------------------------^
/lfs/h2/emc/lam/noscrub/Matthew.Pyle/rrfs-workflow_warnings/sorc/UPP/sorc/ncep_post.fd/io_int_stubs.f(4): warning #6843: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value.   [OUTCOUNT]
SUBROUTINE ext_int_get_dom_ti_real ( DataHandle,Element,   Data, Count, Outcount, Status )

I did a quick test removing these lines from io_int_stubs.f, and it compiled cleanly (but didn't try running with the built executable). So might be an easy fix. 

!--- get_dom_ti_real
 SUBROUTINE ext_int_get_dom_ti_real ( DataHandle,Element,   Data, Count, Outcount, Status )
-  INTEGER ,       INTENT(IN)  :: DataHandle
-  CHARACTER*(*) :: Element
-  REAL ,          INTENT(OUT) :: Data(*)
-  INTEGER ,       INTENT(IN)  :: Count
-  INTEGER ,       INTENT(OUT) :: Outcount
-  INTEGER ,       INTENT(OUT) :: Status
WenMeng-NOAA commented 3 months ago

@MatthewPyle-NOAA Could you submit a PR to the branch 'release/rrfs_v1'? Thanks!

MatthewPyle-NOAA commented 3 months ago

https://github.com/NOAA-EMC/UPP/pull/967

WenMeng-NOAA commented 3 months ago

This issue was solved in the PR #967.