search

NOAA-EMC / UPP

Other
36 stars 98 forks source link

[release/rrfs_v1] Removes lines that generate warnings during compilation #967

Closed MatthewPyle-NOAA closed 3 months ago

MatthewPyle-NOAA commented 3 months ago

Updates io_int_stubs.f to allow for a warning-free compilation. Haven't made runs with this change, but was hoping that regression tests could validate that it doesn't create a problem.

WenMeng-NOAA commented 3 months ago

@MatthewPyle-NOAA I conducted a couple UPP standalone tests with your branch. The fix works well.

MatthewPyle-NOAA commented 3 months ago

Is the Intel Linux Build setup failure a concern, @WenMeng-NOAA ?

WenMeng-NOAA commented 3 months ago

Is the Intel Linux Build setup failure a concern, @WenMeng-NOAA ?

@MatthewPyle-NOAA From my WCOSS2 testing, it works well. Can you specify what kind of failure?

MatthewPyle-NOAA commented 3 months ago

It looks like it might have been a full disk causing the problem. https://github.com/NOAA-EMC/UPP/actions/runs/9448579856

WenMeng-NOAA commented 3 months ago

It looks like it might have been a full disk causing the problem. https://github.com/NOAA-EMC/UPP/actions/runs/9448579856

@MatthewPyle-NOAA That's the failure of CI on github. There might be an update of CI configuration at github. As long as our testing at local platforms like WCOSS2, R&D platforms Hera and Orion, works well, we should be fine. We will solve the UPP CI issue later.