Closed SamuelTrahanNOAA closed 4 weeks ago
The bug fixes were implemented in the RRFS branch 'release/rrfs_v1' to solve the issue of unduplicated RRFS grib2 metadata.
@WenMeng-NOAA - I looked at #979 and I don't see any of the bug fixes from this PR in that one. There are bug fixes, but they're entirely unrelated and do not overlap.
@SamuelTrahanNOAA The bug fixes in #797, first implemented in the develop branch, will ensure to the generation of consistent grib2 metadata in RRFS dataset. example for QPFFG in PRSLEV:
test1:
< 772:4824832913:vt=2024022023:surface:11-12 hour acc fcst:var discipline=1 center=7 local_table=1 parmcat
=1 parm=197:prob >1:prob fcst 72/110
test2:
772:4824832913:vt=2024022023:surface:11-12 hour acc fcst:var discipline=1 center=7 local_table=1 parmcat
=1 parm=197:prob >1:prob fcst 96/110
6177c6177
@SamuelTrahanNOAA Can you sync your branch with the latest UPP develop? We will process your PR.
Before you merge this, I want to confirm the inline post works after I update the branch.
Before you merge this, I want to confirm the inline post works after I update the branch.
@SamuelTrahanNOAA Sure. Right now, we would like you to sync your branch so we can run the UPP RTs.
My branch is updated and the inline post seems to work. (Hera queues were unusually fast today.) This branch is ready for regression testing.
The UPP RTs were completed on WCOSS2 without baseline changes.
@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There should be no baseline update in this PR.
@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There should be no baseline update in this PR.
Permission restrictions on the branch prevent me from pushing RT logs, but there are no changes in RT results on Hera and Hercules. Looks good from my side.
@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There should be no baseline update in this PR.
Permission restrictions on the branch prevent me from pushing RT logs, but there are no changes in RT results on Hera and Hercules. Looks good from my side.
@SamuelTrahanNOAA Can you give access permission to @FernandoAndrade-NOAA so the UPP RT logs can be pushed in your branch?
Can you give access permission to @FernandoAndrade-NOAA so the UPP RT logs can be pushed in your branch?
@FernandoAndrade-NOAA - I invited you as a collaborator to my repository so you can push logs to it. Please check the email connected to your github account for an invitation email. If you accept the invitation, github should let you push logs.
Thanks! We should be good to go for merging, @WenMeng-NOAA
@SamuelTrahanNOAA Can you confirm this PR is working in inline post at ufs-weather-model side before we merge it?
Can you confirm this PR is working in inline post at ufs-weather-model side before we merge it?
The ufs-weather-model baseline generation ran without incident. I didn't check the GRIB files's contents since there are hundreds of them, with thousands of records in each.
The ufs-weather-model code managers will run the regression tests on all supported platforms sometime in the next few weeks. At that point, we'll have broader assurances that the inline post works. However, they don't run regression tests until subcomponent pull requests are merged, including this one. That means you must merge this pull request before we can do large-scale testing of the inline post across all platforms.
@SamuelTrahanNOAA We can merge this PR now and address inline post issues later if needed.
This PR is ready for merging.
Updates UPP to be compatible with the ufs-weather-model inline post. Also fixes a bug that produced thousands of error messages from g2tmpl.
This was originally a PR to add number concentration on pressure levels, but I had to fix those unrelated bugs to get this in the ufs-weather-model.