ww3_grib Excluding wave length

[mmuscato]

Describe the bug Mean wave length (WLM) is being excluded from GRIB OUTPUT.

To Reproduce Add LM to the ww3_grib.inp file.

Expected behavior I see in ww3_grib.F90 where it is excluding this parameter but I also see a spot in the code to handle Mean Wave Length. So should this be no longer excluded from output?

Screenshots N/A

Additional context Thanks!

[JessicaMeixner-NOAA]

@mmuscato can you point to the lines of code that you mention in your expected behavior?

[mmuscato]

@JessicaMeixner-NOAA Yes, starting at line 335 in ww3_grib.F90:

!
  ! Compatibility with NCEP operational codes, same effect as old FLGRIB
  !  lists variables that have no code for variable names (not 100%
  !  correct in old codes... )
  !
  ! Chage this as parameters become available in grib2 tables
  !
      ALLOCATE ( IFIA (13), IFJA(13) ) 

      IFIA = (/ 1, 2, 2, 4, 4, 4, 4, 4, 5, 9, 9, 9, 9 /)
      IFJA = (/ 4, 2, 8, 3, 5, 6, 7, 8, 1, 1, 2, 3, 4 /)
      DO I = 1, 13 
        IF ( FLREQ(IFIA(I),IFJA(I)) ) THEN
          FLREQ(IFIA(I),IFJA(I)) = .FALSE. 
          WRITE(NDSO,946) IDOUT(IFIA(I),IFJA(I)),                      &
                        '*** EXCLUDED FROM GRIB OUTPUT ***'
        END IF
      END DO
!

I think parameter 2,2 can be removed along with 4,3. So it should be like this:

!
! Compatibility with NCEP operational codes, same effect as old FLGRIB
!  lists variables that have no code for variable names (not 100%
!  correct in old codes... )
!
! Chage this as parameters become available in grib2 tables
!
      ALLOCATE ( IFIA (11), IFJA(11) ) 

      IFIA = (/ 1, 2, 4, 4, 4, 4, 5, 9, 9, 9, 9 /)
      IFJA = (/ 4, 8, 5, 6, 7, 8, 1, 1, 2, 3, 4 /)
      DO I = 1, 11 
        IF ( FLREQ(IFIA(I),IFJA(I)) ) THEN
          FLREQ(IFIA(I),IFJA(I)) = .FALSE. 
          WRITE(NDSO,946) IDOUT(IFIA(I),IFJA(I)),                      &
                        '*** EXCLUDED FROM GRIB OUTPUT ***'
        END IF
      END DO
!

[JessicaMeixner-NOAA]

Thank you @mmuscato for providing the additional updates. I'm going to change this from "bug" to "feature request" as it is stated in the code it's excluded.

[mmuscato]

Perfect thank you!