NOAA-EMC / fv3atm

Other
32 stars 157 forks source link

FV3 Changes for using canopy resistance (rca) in Noah-MP for the AQM. #830

Closed drnimbusrain closed 6 months ago

drnimbusrain commented 6 months ago

Description

This PR is associated with changes to ccpp-physics at: https://github.com/ufs-community/ccpp-physics/pull/204, which are proposed to add initial total canopy resistance (rca) calculation in Noah-MP, which is needed for coupling to the Air Quality Model (AQM) component. The rca calculation is based on Bonan et al. (2011) from the CLM4, and is used in the WRF version of the Noah-MP model.

Issue(s) addressed

https://github.com/NOAA-EMC/fv3atm/issues/829

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Compiled with UFS-SRW-App on RDHPCs, Hera. Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
No. Have the ufs-weather-model regression test been run? On what platform?

Do PRs in upstream repositories need to be merged first? If so add the "waiting for other repos" label and list the upstream PRs

grantfirl commented 6 months ago

@jkbk2004 @DusanJovic-NOAA This is combined into https://github.com/NOAA-EMC/fv3atm/pull/831 and therefore it can be closed.