NOAA-EMC / fv3atm

Other
32 stars 157 forks source link

Land surface upgrades for HR4 #855

Closed HelinWei-NOAA closed 3 months ago

HelinWei-NOAA commented 4 months ago

Description

This PR mainly involves changes in ccpp-physics

To address some concerns from HR3 especially the surface cold biases we have finalized some land surface upgrades after carrying out extensive tests and evaluation.

This PR will change results on those suites using NoahMP

The changes have undergone extensive testing within the HR3 framework The changes are covered by regression tests the ufs-weather-model regression test has been run on wcoss2 the code updates will change regression test baseline

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first? If so add the "waiting for other repos" label and list the upstream PRs

grantfirl commented 3 months ago

@HelinWei-NOAA @FernandoAndrade-NOAA https://github.com/ufs-community/ccpp-physics/pull/219 was merged. This is ready to revert .gitmodules and update the ccpp/physics submodule pointer to: https://github.com/ufs-community/ccpp-physics/commit/2a50cccd916cceafaf031f4cd14f2ecef277be8f

FernandoAndrade-NOAA commented 3 months ago

Ok, this should be ready to go. Please continue with merging.