NOAA-EMC / fv3atm

Other
33 stars 157 forks source link

Add soil temperature and moisture IAU #866

Closed tsga closed 1 week ago

tsga commented 3 months ago

Description

The atmospheric DA applies IAU increments on temperature (among other variables), while the land surface increments are applied once at the start of the DA (cycle?) window. This could lead to the land surface (soil and snow) temperature being out of sync with near surface atmospheric temperature

Issue(s) addressed

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

Regression tests for ATM only and coupled (S2S) configurations pass in hera.

Additional land-IAU specific test to be added: control_c48_intel_land_iau (based on the "control_c48_intel" test, with the only difference being the turning on of land IAU and soil temperature increment files inside INPUT directory). The test inputs are at: /scratch1/NCEPDEV/da/Tseganeh.Gichamo/ccpp-physics/test/control_c48_intel_land_iau

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first? If so add the "waiting for other repos" label and list the upstream PRs

Requirements before merging

tsga commented 2 months ago

Can't assign so tagging relevant people here. Please add (tag) anyone you think should be aware. @CoryMartin-NOAA, @barlage, @ClaraDraper-NOAA, @CatherineThomas-NOAA, @junwang-noaa

grantfirl commented 1 week ago

@tsga @jkbk2004 https://github.com/ufs-community/ccpp-physics/pull/222 was merged. This branch is ready to point to the latest ufs/dev commit: https://github.com/ufs-community/ccpp-physics/commit/cfa18610e546ddb633c117afd394bf4aaaeec4dc and have .gitmodules reverted.